Skip to content

Add iMinePlex #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add iMinePlex #102

wants to merge 5 commits into from

Conversation

Parsa3323
Copy link

@Parsa3323 Parsa3323 commented Mar 26, 2025 •
edited
Loading

General:

  • The pull request title is descriptive. (ex. Added GoldenPvP Network, not Updated metadata.json)
  • The pull request does not contain any unrelated commits. (ex. commits from previous pull requests)

Mapping Additions or Updates:

  • Folder with appropriate name has been created / updated (must not include any non-alpha characters or whitespace).
  • No changes were made to the file's formatting (4 spaces per tab).
  • There are no syntax errors.
  • There is no pre-existing mapping matching my id (check if there is an existing folder).
  • My field values match your requirements.
  • You can view our patterns here: metadata.schema.json, or take a look below and complete the field checklist:
    • id: a lowercase string, which should match the folder name (ex. goldenpvpnetwork)
    • name: a string (ex. GoldenPvP Network)
    • description: hook between 16 and 40 characters (ex. We're the home of classic PvP gamemodes)
    • addresses: an array with lowercase strings (ex. ["goldenpvp.net", "routing.center"])
      • You do not need to specify subdomains, CheatBreaker services automatically detect them.
    • primaryAddress: the primary address that people connect to with (please include the subdomain if required) (ex. mc.goldenpvp.net)
    • minecraftVersions: an array with Minecraft versions as strings (ex. ["1.7.*", "1.8.9"] - Must be versions or subversions supported by CheatBreaker)
    • primaryMinecraftVersion: a Minecraft version as a string (ex. 1.7.10 - Must be a subversion supported by CheatBreaker)
    • primaryColor: a hexademical color code that primarily distinguishes the server (ex. #00FFFF)
    • secondaryColor: a hexademical color code that accompanies the primaryColor of the server (ex. #FF0000)
    • primaryRegion: the primary region where your server operates in (ex. EU)
    • regions: a list of regions where you have servers located that service your players (ex. ["EU", "NA", "AS"])
    • gameTypes: a list of games that describe the content on your server, must be a max of 3 listed (ez. ["PVP", "UHC", "HCF"])
    • (optional) website: url of server website, must include URL schema (http:// or https://) (ex. https://www.goldenpvp.net)
    • (optional) store: url of server store, must include URL schema (http:// or https://) (ex. https://store.goldenpvp.net)

Socials

  • (optional) twitter: username of twitter account without the @ (ex. GoldenPvPNet)
  • (optional) discord: invite link to discord (ex. https://discord.com/invite/3EAzBxf)
  • (optional) youtube: slug or username of youtube channel (ex. GoldenPvP)
  • (optional) instagram: username of instagram account (ex. GoldenPvPNet)
  • (optional) twitch: username of twitch account (ex. GoldenPvPNet)
  • (optional) telegram: slug of telegram group (ex. GoldenPvP-Network)
  • (optional) reddit: slug of subdreddit wtih 'r/' (ex. GoldenPvP)
  • (optional) tiktok: username of tiktok account (ex. GoldenPvP)
  • (optional) facebook: slug of facebook page (ex. GoldenPvP)

Media:

Icon

  • My icon is a png file.
  • I have uploaded my icon to my server folder (ex. goldenpvpnetwork) and named it icon.png.
  • My icon has a transparent background and is square (1:1 aspect ratio).
  • My icon is 64 pixels in width and height.
  • My icon is my own/the server's property and complies with relevant copyright/privacy laws.

Logo

  • My logo is a png file.
  • I have uploaded my logo to my server folder (ex. goldenpvpnetwork) and named it logo.png.
  • My logo has a transparent background and is square (1:1 aspect ratio).
  • My logo is 108 pixels in width and height.
  • My logo is my own/the server's property and complies with relevant copyright/privacy laws.

Discord Logo

  • My logo is a png file.
  • I have uploaded my logo to my server folder (ex. goldenpvpnetwork) and named it discord.png.
  • My logo has a transparent background and is square (1:1 aspect ratio).
  • My logo is between 512 and 1024 pixels in width and height.
  • My logo is my own/the server's property and complies with relevant copyright/privacy laws.

Primary Background (Only required for partnered servers)

  • My primary background is a png file.
  • I have uploaded my primary background to my server folder (ex. goldenpvpnetwork) and named it primarybackground.png.
  • My primary background is 774 pixels in width and 363 pixels in height.
  • My primary background contains relevant content pertaining to the server, is my own/the server's property, and complies with relevant copyright/privacy laws.
  • My primary background doesn't contain any markings, text, or logos (unless part of a build).

Secondary Background (Only required for partnered servers)

  • My secondary background is a png file.
  • I have uploaded my secondary background to my server folder (ex. goldenpvpnetwork) and named it secondarybackground.png.
  • My secondary background is 447 pixels in width and 172 pixels in height.
  • My secondary background contains relevant content pertaining to the server, is my own/the server's property, and complies with relevant copyright/privacy laws.
  • My secondary background doesn't contain any markings, text, or logos (unless part of a build).

@Parsa3323
Create metadata.json
af01523 
Signed-off-by: Parsa3323 <[email protected]>
@Parsa3323
Add files via upload
eee2bf2 
Signed-off-by: Parsa3323 <[email protected]>
@Parsa3323
Add files via upload
7a48bae 
Signed-off-by: Parsa3323 <[email protected]>
@Parsa3323
Update metadata.json
bdfd07c 
Signed-off-by: Parsa3323 <[email protected]>
@Parsa3323
Copy link
Author

CAN SOMEONE FUCKING AWNSER?

@Parsa3323 Parsa3323 closed this Apr 7, 2025
@Parsa3323 Parsa3323 reopened this Apr 10, 2025
@ShonP40
Copy link
Member

ShonP40 commented Apr 11, 2025

Tick all the boxes relevant to this PR

ShonP40
ShonP40 requested changes Apr 11, 2025
View reviewed changes
mappings/servers/imineplex/icon.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be your MC server icon (e.g the one you see in your multiplayer menu, which is 64x64 pixels

mappings/servers/imineplex/logo.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in the docs, this needs to be 108x108 pixels

mappings/servers/imineplex/metadata.json
"addresses": [
"iMinePlex.iR"
],
"primaryAddress": "Play.iMinePlex.iR",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be lowercase

mappings/servers/imineplex/metadata.json
"name": "iMinePlex",
"description": "Play without lag",
"addresses": [
"iMinePlex.iR"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be lowercase

mappings/servers/imineplex/metadata.json
"minecraftVersions": [
"1.8.*",
"1.9.*",
"1.20.*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't support 1.9 or 1.20.
This list should only include versions which both your server and CB support

mappings/servers/imineplex/metadata.json
"PvP",
"Minigames"
],
"website": "https://iMinePlex.iR/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL redirects to some random online shop (not related to MC at all)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but its mine, it will be added soon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So remove it for now and make a new PR once it does go to your server's website

mappings/servers/imineplex/metadata.json
"Minigames"
],
"website": "https://iMinePlex.iR/",
"store": "https://Store.iMinePlex.iR/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This website doesn't exist

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it doesn't, but it will

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So remove it for now and make a new PR once you actually set up a store

mappings/servers/imineplex/discord.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Discord logo resolution can't exceed 1024x1024

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i'll fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShonP40 ShonP40 ShonP40 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Parsa3323 @ShonP40