Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eventsub): use snake_case transform by default #5916

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Feb 7, 2025

Fixes #5911

This includes a refactor of how comment commands are stored

Now, instead of each place doing the parsing/handling, it's just one
class handling the parsing with some helper functions for applying
certain commands.
Copy link
Member Author

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@pajlada pajlada changed the title refactor(eventsub): use snake_case transform by default refactor(eventsub): use snake_case transform by default Feb 7, 2025
@pajlada pajlada merged commit 02405b9 into master Feb 7, 2025
18 checks passed
@pajlada pajlada deleted the chore/eventsub-default-json-transform branch February 7, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default of json_transform should be snake_case since it will be used most
1 participant