Feature/update line numbers #243
Open
+476
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chakroun-Anas
force-pushed
the
master
branch
from
2d7d212 to
7a5ac64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #238 , by adding two new commands: "turboConsoleLog.updateAllLogMessages" and "turboConsoleLog.updateLogMessage".
Demo
The former detects all log messages (by calling the
.detectAll()method), and replace the line with the new updated line. The.updateFileNameAndLineNum()method inJSDebugMessageclass does a simple regex change.The latter limits the update only to the lines in the
editor.selections.There are no tests, and it is a bit naive at the moment. If you are more interested, I can dive into the test codes as well. Feel free to leave a comment.
Thanks.