Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSX Compatibility for SVG Attribute #1753

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: JSX Compatibility for SVG Attribute #1753

merged 1 commit into from
Jan 20, 2025

Conversation

ishaansehgal99
Copy link
Contributor

Use JSX for fillRule and clipRule

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. frontend Pertains to the frontend. labels Jan 20, 2025
@ishaansehgal99
Copy link
Contributor Author

This code resolves browser error I received for unrecognized params - fill-rule and clip-rule.

dokterbob
dokterbob requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@dokterbob dokterbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great contrib.

Any chance you could enable eslint-plugin-svg-jsx to see if there's other such beasts?

See: https://www.useanvil.com/blog/engineering/eslint-plugin-svg-jsx/

willydouhard
willydouhard approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willydouhard willydouhard merged commit 65060cc into Chainlit:main Jan 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokterbob dokterbob dokterbob requested changes

@willydouhard willydouhard willydouhard approved these changes

Assignees
No one assigned
Labels
frontend Pertains to the frontend. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishaansehgal99 @dokterbob @willydouhard