feat: allow developers to bypass the docker build #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ILD environment variable
noot
reviewed
Mar 20, 2023
| @@ -10,9 +10,12 @@ Ensure that docker is installed on the machine where the tests need to be run. | |||
|
|
|||
| Then, run the following as usual. | |||
| ``` | |||
| cargo test | |||
| DOCKER_BUILD=1 cargo test | |||
There was a problem hiding this comment.
does the value this is set to matter, or does it just need to be set for env::var("DOCKER_BUILD").is_ok() to be true?
There was a problem hiding this comment.
The value doesn't matter. Just that it is set to something. So you could do DOCKER_BUILD=candy and that would work also.
noot
reviewed
Mar 20, 2023
noot
reviewed
Mar 20, 2023
stonecharioteer
force-pushed
the
stonecharioteer/optional-docker-build
branch
from
538e325 to
cb4676a
Compare
|
I used act to test the action locally. Made some slight improvements to the action file itself, let's see if it works here. |
* Update README to showcase how to write tests using the macro instead * Update README to note about the ws:// prefix. * Update github actions to use the rust action instead of setting the stable toolchain manually, and use `DOCKER_BUILD` flag at least once before the tests. * Run multiple tests simultaneously.
stonecharioteer
force-pushed
the
stonecharioteer/optional-docker-build
branch
from
cb4676a to
9c979be
Compare
noot
reviewed
Mar 23, 2023
| } | ||
| } | ||
| ``` | ||
|
|
||
| One can create as many of these as needed, limited only by the server resources. | ||
|
|
||
| **NOTE**: When using a URI for connections, ensure that you're prefixing the |
There was a problem hiding this comment.
this might be sort of confusing since dialer_uri already has ws:// in it? I'd just remove this for now lol
noot
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DOCKER_BUILDenvironment variable is set.`Tests
To build the docker image before running tests:
DOCKER_BUILD=1 cargo testTo run tests normally,
cargo testNote that you could use this with
cargo checkandcargo buildas well, but that doesn't work really.Issues