fix: chain follower gets stuck in some cases #5675
Open
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
requested review from
LesnyRumcajs and
sudo-shashank
and removed request for
a team
src/chain_sync/chain_follower.rs
Outdated
Comment on lines
571
to
582
| } else if let Ok(parent_ts) = load_full_tipset(&self.cs, tipset.parents().clone()) { | ||
| let head_ts = self.cs.heaviest_tipset(); | ||
| if parent_ts.key() == head_ts.key() { | ||
| true | ||
| } else if parent_ts.epoch() >= head_ts.epoch() { | ||
| false | ||
| } else { | ||
| self.cs | ||
| .blockstore() | ||
| .has(parent_ts.parent_state()) | ||
| .unwrap_or(false) | ||
| } |
There was a problem hiding this comment.
Would you mind adding comments around those in plain English to explain what is happening and why? I think given the complexity of this, we should strive for as much documentation as possible.
LesnyRumcajs
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
I happened to run into #5679 on mainnet after rebooting the node during chain catchup validation. After setting chain head to a few epochs back, the node was still stuck (No tipset download jobs are scheduled),
With changes in this PR, my node was able to resume following the chain, however, I cannot reproduce the issue, but found another bug #5677
This PR should fix #5677 and might fix #5679
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #5677
Closes #5679
Other information and links
Change checklist