chore: contact email -> dcm.anonimizer@gmail.com + F-batch hygiene (TD-053/054/059/061) - #1
Conversation
Prior-session uncommitted fixes, validated together (82/82 tests pass): - TD-053: hard-code the demo DICOM UIDs in scripts/make_demo_dicom.py so the SHA-256 published in docs/demo.md no longer depends on the UIDs pydicom happens to ship in its bundled CT_small.dcm. - TD-054: hoist `import asyncio` to module top in routes/anonymize.py (was a copy-paste of the pre-fix in-body import). - TD-059: accumulate webhook deadletter rows and commit once after the loop in webhook_delivery.py, so N failing targets for one customer produce a single transaction instead of N. - TD-061: models.py OutgoingWebhook.active column is now Boolean to match its Mapped[bool] annotation (SQLite stores 0/1, so existing rows + the active==1 query stay compatible).
Replaces plusultra.dev@proton.me across README, SECURITY.md, pricing.md, the docs (compliance, subprocessors) and the legal templates (ToS, privacy, DPA, invoice). The [SPANISH ADDRESS] / NIF [TO PROVIDE] fiscal placeholders are unchanged (still principal-gated). No code change.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd98860519
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Boolean so the runtime column type matches the Mapped[bool] annotation | ||
| # (TD-061). SQLite stores bool as 0/1, so existing vault.db rows and the | ||
| # ``active == 1`` query in webhook_delivery remain compatible. | ||
| active: Mapped[bool] = mapped_column(Boolean, nullable=False, default=True) |
There was a problem hiding this comment.
For deployments that followed docs/deploy.md and used Postgres before this change, outgoing_webhooks.active already exists as an INTEGER column because init_db() only calls create_all() and does not alter existing tables. Remapping the ORM column to Boolean now causes webhook filters/inserts to bind boolean values against that existing integer column, so registration or delivery can fail on Postgres until operators manually ALTER the schema; add an explicit migration/compatibility path or keep the integer mapping until one exists.
Useful? React with 👍 / 👎.
1 participant
Two commits: (1) prior-session F-batch tech-debt hygiene fixes TD-053/054/059/061 (validated, 82/82 tests pass); (2) contact email change plusultra.dev@proton.me -> dcm.anonimizer@gmail.com across README/SECURITY/pricing/docs/legal. Fiscal [SPANISH ADDRESS]/NIF placeholders untouched (principal-gated).