-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arie comments #343
Arie comments #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is missing: #335 (comment).
I did not check, but are the following addressed?
- DOC-433 | CERT-7992 | Added solana cli options #335 (comment)
- DOC-433 | CERT-7992 | Added solana cli options #335 (comment)
- DOC-433 | CERT-7992 | Added solana cli options #335 (comment)
Spell checking is failing as well.
``` | ||
|
||
## Most Frequently Used Options | ||
|
||
(--solana_inlining)= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to compile the documentation with this?
I don't think it looks as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what we've done in the solidity docs
Documentation/docs/prover/cli/options.md
Line 31 in 49ae6f3
(--verify)= |
Addressed comments which are relevant. Some fixes you already did in the main branch after merging the original PR. |
Naming convention:
Before requesting review:
spelling_wordlist.txt
README.md
for information about style and markdown syntaxJira ticket: TODO
Link to generated documentation: TODO