-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-430 | Documentation for Sanity Check for Solana #337
DOC-430 | Documentation for Sanity Check for Solana #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only minor comments.
Feel free to incorporate or reject them.
docs/solana/sanity.md
Outdated
cvt_assume!(amount >= 2); | ||
cvt_assume!(amount <= 1); | ||
cvt_assert!(amount == 1); //Expect a sanity failure here as the assumes are conflicting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think that we are using the prefix cvlr_
for our functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. This is something to keep an eye on in particular.
I think that there are still some comments in the "hidden" section that maybe should be merged (e.g. the double that). |
👍 I'll doube check |
Naming convention:
Before requesting review:
spelling_wordlist.txt
README.md
for information about style and markdown syntaxJira ticket: TODO
Link to generated documentation: TODO