Skip to content

Jz fix seq2 seq #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jingzhi93 wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Jz fix seq2 seq #24

jingzhi93 wants to merge 15 commits into from

Conversation

@jingzhi93
Copy link
Contributor

@jingzhi93 jingzhi93 commented Dec 28, 2020

No description provided.

@jingzhi93
Add Seq2Seq examples
4e8ada1
@jingzhi93
Add seq2seq examples
b6efcff 
add Seq2Seq Basics and Sunspot example
@KianYang-Lee
Copy link
Contributor

KianYang-Lee commented Jan 21, 2021

Dear @evanyeohboonkhai your review is needed on this just a reminder Tq.

@evanyeohboonkhai
Copy link
Contributor

evanyeohboonkhai commented May 24, 2021 •
edited
Loading

Hi Team, I have added some modification to the seq2seq.
Modification:

  • Some of the coding
  • Add instruction and description
    Please have a view of these.Thanks
    @scot-certifai @KianYang-Lee

@evanyeohboonkhai evanyeohboonkhai self-assigned this May 24, 2021
@jingzhi93
Copy link
Contributor Author

jingzhi93 commented Jun 9, 2021 •
edited
Loading

04 - Seq2Seq Basics

  1. the dunder function getitem allows the use of [], don't need to specify it in a function
  2. lack of description for "Model evaluation" and "Inverse transform"
  3. fix the plot
  4. add description to differentiate single step and multi-step
  5. fix multistep output

@evanyeohboonkhai
Copy link
Contributor

evanyeohboonkhai commented Jul 1, 2021

Fix both the basic and sunspot notebook, and update environment file for new add plotly library @jingzhi93, please have a view on this. Thanks

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@review-notebook-app
Copy link

review-notebook-app bot commented Aug 23, 2021

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@evanyeohboonkhai evanyeohboonkhai evanyeohboonkhai approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@evanyeohboonkhai evanyeohboonkhai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jingzhi93 @KianYang-Lee @evanyeohboonkhai @scotgopal