Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines an alternative XML reader based on
lxml(without Beautiful soup). The class is very simple; extractors are defined using XPath. The unit tests include some examples.This reader is generally much faster than the
XMLReader, but offers fewer features. (The speed gain is mostly in the initial parsing of the XML file.)This was built as a proof-of-concept, but we're not planning to merge it currently. We don't want to replace the XMLReader with this one (due to the lack of features), or have two readers side-by-side.
The tests currently fail for Python 3.9, due to a compatibility issue in the test itself; the reader should work fine in Python 3.9.