Skip to content

Use typer for cli and refactor - #141

Merged
matthdsm merged 10 commits into
masterfrom
feat/typer
Feb 23, 2026
Merged

matthdsm merged 10 commits into
masterfrom
feat/typer

Conversation

@matthdsm

Copy link
Copy Markdown

No description provided.

@matthdsm
matthdsm requested a review from nvnieuwk February 23, 2026 10:38
Comment thread src/wisecondorx/convert_tools.py Outdated
import logging

import sys
from typing import Dict, Tuple, Optional

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't normal typing already part of python >=3.10?

nvnieuwk
nvnieuwk previously approved these changes Feb 23, 2026

@nvnieuwk nvnieuwk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nvnieuwk nvnieuwk left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@matthdsm
matthdsm merged commit 39db53b into master Feb 23, 2026
1 check passed
@matthdsm
matthdsm deleted the feat/typer branch March 26, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants