-
Notifications
You must be signed in to change notification settings - Fork 0
LVP bug fixes #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LVP bug fixes #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements bug fixes for master reports and bubble plots in the LangPA validation tools. The changes primarily address visualization improvements, dependency updates, and system prompt handling in the DeepSearch service.
Key Changes
- Updated bubble plot visualization to use program indices on axes with overlap-count-based bubble sizing, replacing the previous gene Jaccard/name similarity scatter plot approach
- Added
overlap_countfield toSimilarityScoresmodel to track the number of overlapping genes between matched programs - Upgraded
url2refdependency from v1.0-beta to v1.2-beta and addedciteproc-pydependencies for citation processing - Improved path handling in master report generation with
_safe_relpath()helper function to handle cross-drive scenarios - Added explicit system prompt resolution in DeepSearchService with validation and warnings for model-prompt incompatibilities
- Changed default
use_pydanticparameter toTrueinprocess_and_save_structured_output()
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated url2ref dependency and added citeproc-py packages for citation handling |
| langpa/pyproject.toml | Added citeproc-py dependency declaration |
| langpa_validation_tools/src/langpa_validation_tools/visualization/heatmaps.py | Refactored bubble plot to use program indices as axes with overlap-based sizing; added return_fig parameter |
| langpa_validation_tools/src/langpa_validation_tools/reporting/master_report.py | Added _safe_relpath() helper to handle relative path calculation across drives |
| langpa_validation_tools/src/langpa_validation_tools/comparison/models.py | Added overlap_count field to SimilarityScores model |
| langpa_validation_tools/src/langpa_validation_tools/comparison/matching.py | Updated to calculate and store overlap_count in similarity scores |
| langpa_validation_tools/src/langpa_validation_tools/analysis/run_comparison.py | Added genes_a_count and genes_b_count to output DataFrame |
| langpa_validation_tools/tests/unit/test_*.py | Updated tests to include new overlap_count, genes_a_count, genes_b_count fields |
| langpa/src/langpa/services/deepsearch_service.py | Added cache_config parameter, _resolve_system_prompt() method with validation and warnings |
| langpa/src/langpa/services/deepsearch_prompts.py | Clarified output format instructions for schema_embedded template |
| langpa/src/langpa/services/deepsearch_configs.py | Added explicit system prompt constants |
| langpa/src/langpa/services/output_manager.py | Changed use_pydantic default from False to True |
| 20251212_121027/ | Runtime output files that should not be in version control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
langpa_validation_tools/src/langpa_validation_tools/analysis/run_comparison.py
Show resolved
Hide resolved
langpa_validation_tools/src/langpa_validation_tools/visualization/heatmaps.py
Show resolved
Hide resolved
langpa_validation_tools/src/langpa_validation_tools/visualization/heatmaps.py
Outdated
Show resolved
Hide resolved
…ion/heatmaps.py Co-authored-by: Copilot <[email protected]>
Co-authored-by: dosumis <[email protected]>
Co-authored-by: dosumis <[email protected]>
Co-authored-by: dosumis <[email protected]>
Remove duplicate Args section from generate_bubble_plot docstring
Remove committed runtime output files and add gitignore pattern
Leaving LVT fixes
Fixes for master reports, bubble plots.