PAINTROID-782 Use file picker for choosing file saving location #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalid-nasralla
force-pushed
the
PAINTROID-782
branch
8 times, most recently
from
dfba0dc to
7bd7fad
Compare
PAINTROID-782 Use file picker for choosing file saving location
khalid-nasralla
force-pushed
the
PAINTROID-782
branch
from
7bd7fad to
0c637e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAINTROID-782 Use file picker for choosing file saving location
Changed the old file saving to use the Storage Access Framework (SAF). It replaces the saving into emulated storage with a file-picker.
Cleaned up/Removed old FileIO logic and removed legacy code that was for saving into emulated storage.
Lots of updates in the code and also for tests that were written for the old file saving and became redundant.
Removed/Disabled legacy "Save Copy" option from the menu, because the SAF file picker can do the same without having to do it manually.
Removed manual overwriting of file that can also be done with the SAF file picker (built in by holding file until it is selected and then saving with the same name)
New Image option works aswell now with the new file picker when it asks if the user wants to save the current image.
Added a couple of tests for the new functionality
Include the name of the Jira ticket in the PR’s title
Include a summary of the changes plus the relevant context
Choose the proper base branch (develop)
Confirm that the changes follow the project’s coding guidelines
Verify that the changes generate no compiler or linter warnings
Perform a self-review of the changes
Verify to commit no other files than the intentionally changed ones
Include reasonable and readable tests verifying the added or changed behavior
Confirm that new and existing unit tests pass locally
Check that the commits’ message style matches the project’s guideline
Stick to the project’s gitflow workflow
Verify that your changes do not have any conflicts with the base branch
After the PR, verify that all CI checks have passed
Post a message in the #paintroid Slack channel and ask for a code reviewer