Skip to content

Conversation

@reichli
Copy link
Contributor

@reichli reichli commented Mar 14, 2025

https://catrobat.atlassian.net/browse/CATROID-1607

Bluetooth now works again across all devices. Depending on the device running the app either the new or the legacy bluetooth permissions are used. This is achieved by streamlining/simplifying the permission handling process for all features that require bluetooth permissions.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@sonarqubecloud
Copy link

@ThorstenBandel ThorstenBandel self-requested a review May 2, 2025 13:00
@ThorstenBandel
Copy link
Contributor

Please check Tests => Lego Tests need Bluetooth permissions

@reichli reichli force-pushed the CATROID-1607 branch 2 times, most recently from 4cf4308 to 0159d93 Compare May 15, 2025 15:06
@sonarqubecloud
Copy link

@reichli reichli force-pushed the CATROID-1607 branch 2 times, most recently from fd3efb9 to 14ed1d7 Compare November 18, 2025 17:32
Bluetooth now works again across all devices. Depending on the device
running the app either the new or the legacy bluetooth permissions are
used.
This is achieved by streamlining/simplifying the permission handling
process for all features that require bluetooth permissions.
And a little bit of boyscouting through the code.
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants