[pull] master from breakfastquay:master #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ng implausibly high output values
…tra sample (due to incremental rounding) added up and eventually overran the filter. I believe +1 is perfectly good here, but we can afford to be more accommodating just in case
…nly by a constant amount - because if this arises because of an overlong increment being broken down into littler bits, we would end up doing it again and again, which is much more expensive. This makes a huge performance difference in cases where a time map ends up mapping very little input into a great expanse of output
…nly by a constant amount - because if this arises because of an overlong increment being broken down into littler bits, we would end up doing it again and again, which is much more expensive. This makes a huge performance difference in cases where a time map ends up mapping very little input into a great expanse of output
|
Best reviewed: commit by commit
Optimal code review plan
|
pull
bot
added
⤵️ pull
and removed
🔍 Ready for Review
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks(click to expand)77.78%[src/dsp/Resampler.cpp] 0.00%[src/audiocurves/SpectralDifferenceAudioCurve.cpp] 0.00%[src/StretcherImpl.cpp] 77.78%[src/system/VectorOps.h] 0.00%[src/system/Allocators.h] 0.00%[configure.ac] 0.00%[src/audiocurves/HighFrequencyAudioCurve.cpp] 0.00%[rubberband/RubberBandStretcher.h] 0.00%[.travis.yml] 94.44%[README.md] |
…tter-behaved when changing rates
…er code, bu t it's less sensitive to compile options.
…there is some unpleasant randomness here
Use `cp -p` rather than `cp`
…ild) with _MSC_VER (which the compiler defines itself) throughout
…sable-ladspa is not provided
…adspa.h - bizarre, but whatever
… notation now our computers are all so fast
…cos-universal variant that explicitly does x86_64 + arm64 build
… taking too long to start up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )