Web worker #232
Open
Web worker #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey are available. This is probably still not as efficient as it could be as we are not recycling workers.
…sTile. Not sure this is used any more but just to be safe.
| } | ||
| else{ | ||
| var worker = this.createProccessTileWorker() | ||
| worker.onmessage = function(e){ |
There was a problem hiding this comment.
I don't understand this, why the worker is terminated when recieves a message (maybe is because I don't actully know the webworkers api)
There was a problem hiding this comment.
The worker is only terminated when its done. worker.onmessage is triggered when the worker sends a message back to the main thread.
We could recycle the workers but that requires adding some pool logic which seems overkill just now
|
sounds pretty good, the CI didn't pass, I think it got stuck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the tileJSON provider to use webworkers. It should fall back to processing on the main thread if no webworkers are available. Might still be some speed up we can get by recycling the webworkers but for now this should offload some of the tile processing.
Haven't had a chance to test it with torque_machine just yet but the examples/tilejson.html example works.
@javisantana