Internal provider #221
Open
Internal provider #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new default styles
getbounds now work
getCategories is not random anymore :-/
|
@fdansv please CR |
| @@ -85,7 +85,7 @@ MercatorProjection.prototype.latLonToTilePoint = function(lat, lon, tileX, tileY | |||
| var worldCoordinate = this._fromLatLonToPoint(lat, lon); | |||
| var pixelCoordinate = new Point(worldCoordinate.x*numTiles, worldCoordinate.y*numTiles); | |||
| var tilePixelPos = this._tilePixelPos(tileX, tileY); | |||
| return new Point(Math.round(pixelCoordinate.x-tilePixelPos.x), Math.round(pixelCoordinate.y-tilePixelPos.y)); | |||
| return new Point(Math.round(pixelCoordinate.x-tilePixelPos.x), this._tileSize - Math.round(pixelCoordinate.y-tilePixelPos.y)); | |||
There was a problem hiding this comment.
couldn't this break other providers?
There was a problem hiding this comment.
No one appears to be using those functions, but I can always handle that on my provider if you prefer.
|
Tests? 😄 Other than that I've no objections |
|
No tests yet, you told me to PR what I had ;-) |
|
I want this so bad. :) If this gets rebased on master with some tests, is it mergeable? 💖 |
|
@eightysteele of course! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provider that takes data from an external source (csv file example included) and works directly with the data in memory.
Documentation needs to be really improved, but code should already be reasonably legible.