maybe bug in prepare & load's order #598
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
🐛 Describe the bug
https://github.com/CarperAI/trlx/blob/main/trlx/trlx.py#L140
this load function may be called after prepare in
https://github.com/CarperAI/trlx/blob/main/trlx/trainer/accelerate_base_trainer.py#L86
according to
https://huggingface.co/docs/accelerate/usage_guides/checkpoint
this may cause the loading not work actually, such as deepspeed model
Which trlX version are you using?
No response
Additional system and package information
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Activity
daiwk commentedon Jul 28, 2024
this commit could help in my situation
Jingru@39f1ae9