Skip to content

maybe bug in prepare & load's order #598

Open

Description

@daiwk

🐛 Describe the bug

https://github.com/CarperAI/trlx/blob/main/trlx/trlx.py#L140
this load function may be called after prepare in
https://github.com/CarperAI/trlx/blob/main/trlx/trainer/accelerate_base_trainer.py#L86
according to
https://huggingface.co/docs/accelerate/usage_guides/checkpoint

this may cause the loading not work actually, such as deepspeed model

Which trlX version are you using?

No response

Additional system and package information

No response

Activity

  1. daiwk commented on Jul 28, 2024

    @daiwk
    Author

    this commit could help in my situation
    Jingru@39f1ae9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions