Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
node_modules
linker script and;The linker script itself is a refactor which constraints
node_modules
symlink creation to under[name].runfiles/
, and performs the symlink creation in a fault tolerant manner (as multiple processes may be trying to create it at the same time).This also includes part of a workaround for environments such as EngFlow which reset
[name].runfiles/
when using remote persistent workers, where the information needed to create symlinks is exposed to user code (where it can be run in each worker loop iteration).TODO
internal/linker/BUILD.bazel
whichload
s dev dependencies.