Skip to content

fix(init.sh): correct grammar in comment about creating sample.json #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(init.sh): correct grammar in comment about creating sample.json #2000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/bootstrap/init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if [ ! -d ${data_path}/mdl ]; then
mkdir ${data_path}/mdl
fi

# put a emtpy sample.json if not exists
# put an emtpy sample.json if not exists
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix the spelling error in the comment.

The grammar correction from "a" to "an" is appropriate; however, the comment contains a spelling error: "emtpy" should be "empty". Since this PR is updating the comment, apply both corrections in one pass.

Apply this diff to fix both the grammar and spelling:

-# put an emtpy sample.json if not exists
+# put an empty sample.json if not exists
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# put an emtpy sample.json if not exists
# put an empty sample.json if not exists
🤖 Prompt for AI Agents 
In docker/bootstrap/init.sh around line 26, the comment reads "put an emtpy
sample.json if not exists" which has a spelling error and wrong article; update
the comment to read "put an empty sample.json if not exists" (replace "emtpy"
with "empty" and keep "an" for correct grammar).

if [ ! -f ${data_path}/mdl/sample.json ]; then
echo "init mdl/sample.json"
echo "{\"catalog\": \"test_catalog\", \"schema\": \"test_schema\", \"models\": []}" >${data_path}/mdl/sample.json
Expand Down