Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things I needed to get this to compile #287

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krugar
Copy link

@krugar krugar commented Nov 6, 2019

Additionally to what's in the PR,

I had to manually run npm i --save @csegames/camelot-unchained in Camelot-Unchained/game/hud, as that correctly uses the private registry, even if yarn doesn't.

I also had to set "forceConsistentCasingInFileNames": false in my tsconfig.json to squash TS1149 errors with import statements from hud/..., due to the directory on disk being named HUD.

I've not included either in the PR because it might be somehow specific to my setup here.

@sysrage
Copy link

sysrage commented Nov 6, 2019

Since yarn was ignoring the private registry in .npmrc, we tried adding the following to .yarnrc:

"@csegames:registry" "http://registry.camelotunchained.com"

This doesn't seem to work.

@sysrage
Copy link

sysrage commented Nov 7, 2019

While working with Salty, we found that everything breaks again if Node is upgraded to 12.x. The above workarounds only work with Node 10.x.

@krugar
Copy link
Author

krugar commented Nov 7, 2019

Right, I should have stated that I tried this with LTS/Dubnium (v10.17.0 at time of writing), given that the project requires v7.4.X, which I would read as LTS/Carbon (v8.16.2 atm)?

edit: btw, CircleCI failed because hatcheryapi was down broken at the time:

@csegames/camelot-unchained: nps is executing definitions : download https://hatcheryapi.camelotunchained.com/codegen/definitions.ts > ./src/webAPI/definitions.ts
@csegames/camelot-unchained: HTTPError: Response code 500 (Internal Server Error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants