Improve Context Menu behaviour #200 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mehuge
force-pushed
the
cu-fix-right-click-unit-frame
branch
from
97815cc to
bd32fcb
Compare
codecorsair
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes part way to solving the right click context menu issues described in #200
It does the following:
don't display the context menu if there are no options. This means that if you happen to right click your own portrait and you are not in a warband you won't get a context menu so it wont steal further right clicks (though it still steals the initial one).
if the context menu is open, left or right clicking anywhere but on an option will close it. This still means that the click to close the menu is stolen from the client, so still steals two right clicks requiring a third to turn.
Also fixed z-order of the menu so the options are not behind the unit frame.
This is not a complete solution to the problem described in #200