This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Improve beacon API specification coverage #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
force-pushed
the
feature/do_stuff
branch
14 times, most recently
from
cf037bc to
9af24ed
Compare
blankdots
force-pushed
the
master
branch
2 times, most recently
from
b2cf830 to
fc22365
Compare
blankdots
force-pushed
the
feature/do_stuff
branch
2 times, most recently
from
19a42d3 to
b0b28fb
Compare
blankdots
force-pushed
the
feature/do_stuff
branch
2 times, most recently
from
43528ca to
410ae15
Compare
blankdots
force-pushed
the
feature/do_stuff
branch
from
410ae15 to
7a109a6
Compare
blankdots
added
release
1000 Genomes container
blankdots
added
enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve beacon API specification coverage by addressing some of the misses identified such as:
CONTROLLEDis assuming the permissions are coming in the token and can be later addedAt the same time we introduce integration testing and server caching to improve performance:
infoendpoint was under-performing thus we added simple memory cache to it.Added:
variantTypekey todatasetAlleleResponsesobjectcountsinterpretation as pointed at Clarify the counts in Beacon response ga4gh-beacon/specification#237 (comment)