-
Notifications
You must be signed in to change notification settings - Fork 51
feat: use original Copernicus provider to list queryables of wekeo_ecmwf
#1897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dalpasso
wants to merge
8
commits into
develop
Choose a base branch
from
queryables-constraints-mismatch
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the discovery of queryables has been changed and the test has been adapted.
Code Coverage (Ubuntu)Diff against developResults for commit: d1a9f2a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Code Coverage (Windows)Diff against developResults for commit: d1a9f2a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider
wekeo_ecmwfdoesn't provide the constrains and form URLs. This causes a different list of queryables compared to the original Copernicus provider.Description
This PR enhances the
WekeoECMWFSearchplugin with dynamic discover queryables. A list of configurations is given in the new propertydynamic_discover_queryables. The configuration of the first collection selector that matcheskwargs[field].startswith(prefix)is used. If no one is found, it falls back to standard behaviors. Follows and example of configuration.A new converter
wekeo_to_cop_collectionhas been added to convert the name of a collection from the WEkEO format to the Copernicus format (e.g.EO:ECMWF:DAT:SATELLITE_CARBON_DIOXIDE->satellite-carbon-dioxide).A bug was fixed in the metadata formatter to allow the usage of colons
:as argument of the converter function (e.g.{dataset#wekeo_to_cop_collection(EO:ECMWF:DAT:)}).