Omit end variables in scheduling constraints #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimosts
requested changes
Jun 30, 2025
| demand_at_t += demand * ((start[job] <= t) & (t < end[job])) | ||
| else: | ||
| demand_at_t += demand[job] * ((start[job] <= t) & (t < end[job])) | ||
| demand_at_t += demand[job] * ((start[job] <= t) & (start[job] + duration[job] > t)) |
There was a problem hiding this comment.
Why remove the above? It covers the case that the demand is given as a single number
There was a problem hiding this comment.
It is fixed in the constructor (already a while, but decompose was not adapted yet)
| assert is_any_list(start), "start should be a list" | ||
| assert is_any_list(duration), "duration should be a list" | ||
| assert is_any_list(end), "end should be a list" | ||
|
|
||
| assert demand is not None, "demand should be provided but was None" | ||
| assert capacity is not None, "capacity should be provided but was None" |
There was a problem hiding this comment.
I don't know what should be done here, but I am not really a fan of giving them a default value (making them optional) and then not allowing the optional value.
There was a problem hiding this comment.
Yeah I also agree it is quite annoying... For now this is the best I could come up with, as you cannot make an argument in the middle optional...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to omit the end variables in scheduling constraints such as Cumulative and NoOverlap.
Makes
endNone by default, and adapts solver behaviour accordingly.It was not possible to make the "dummy" end variables in the constructor, as then they would be added to
user_varsin the solver interface, which is incorrect.Most solvers don't actually need the
endvariables in their interface either, except for OR-Tools.Added a helper-function
get_end_varsto create these dummy end variables.