Update sitemap links according to language#152
Conversation
🚨 Preview Deployment Blocked - Security ProtectionYour pull request was blocked from triggering preview deployments Why was this blocked?
How to resolve this:Option 1: Get Collaborator Access (Recommended) Option 2: Request Permission Override For Repository Administrators:To disable this security check ( This security measure protects against malicious code execution in preview deployments. Only trusted collaborators should have the ability to trigger deployments. 🛡️ Learn more about this security featureThis protection prevents unauthorized users from:
Preview deployments are powerful but require trust. Only users with repository write access can trigger them. |
|
I think we should use useLocalePath to resolve paths instead of hard-coding paths in the translation files. Existing landing page links hard-code because they're external. @mirumodapon, what do you think? |
Since the links are already defined in the locale messages, using them directly also seems like a reasonable approach. That said, if we decide to adopt For now, I personally prefer keeping things simple and using the links directly from the locale messages. Just wondering—does this approach have any potential drawbacks we should be aware of? |
|
Good day @rileychh and @mirumodapon. @mirumodapon is right on how I approached it. I just based the fix on the existing implementation of the sitemap links. |
|
Hi there, |
|
Thank you @mirumodapon! :) |
This makes the sitemap links change depending on the selected website language.
This fixes issue #151.