Skip to content

Update sitemap links according to language#152

Merged
mirumodapon merged 1 commit into
COSCUP:mainfrom
harriebird:fix/change-sitemap-links-according-to-selected-language
May 12, 2026
Merged

Update sitemap links according to language#152
mirumodapon merged 1 commit into
COSCUP:mainfrom
harriebird:fix/change-sitemap-links-according-to-selected-language

Conversation

@harriebird
Copy link
Copy Markdown
Contributor

This makes the sitemap links change depending on the selected website language.

This fixes issue #151.

@rileychh-dokploy-coscup
Copy link
Copy Markdown

🚨 Preview Deployment Blocked - Security Protection

Your pull request was blocked from triggering preview deployments

Why was this blocked?

  • User: harriebird
  • Repository: 2026
  • Permission Level: read
  • Required Level: write, maintain, or admin

How to resolve this:

Option 1: Get Collaborator Access (Recommended)
Ask a repository maintainer to invite you as a collaborator with write permissions or higher.

Option 2: Request Permission Override
Ask a repository administrator to disable security validation for this specific application if appropriate.

For Repository Administrators:

To disable this security check (⚠️ not recommended for public repositories):
Enter to preview settings and disable the security check.


This security measure protects against malicious code execution in preview deployments. Only trusted collaborators should have the ability to trigger deployments.

🛡️ Learn more about this security feature

This protection prevents unauthorized users from:

  • Executing malicious code on the deployment server
  • Accessing environment variables and secrets
  • Potentially compromising the infrastructure

Preview deployments are powerful but require trust. Only users with repository write access can trigger them.

@rileychh
Copy link
Copy Markdown
Member

I think we should use useLocalePath to resolve paths instead of hard-coding paths in the translation files. Existing landing page links hard-code because they're external. @mirumodapon, what do you think?

@mirumodapon
Copy link
Copy Markdown
Collaborator

I think we should use useLocalePath to resolve paths instead of hard-coding paths in the translation files. Existing landing page links hard-code because they're external. @mirumodapon, what do you think?

Since the links are already defined in the locale messages, using them directly also seems like a reasonable approach.

That said, if we decide to adopt useLocalePath, we may need a bit more refactoring—ideally, the locale messages should only contain labels, while route definitions are handled in JS.

For now, I personally prefer keeping things simple and using the links directly from the locale messages.

Just wondering—does this approach have any potential drawbacks we should be aware of?

@harriebird
Copy link
Copy Markdown
Contributor Author

Good day @rileychh and @mirumodapon. @mirumodapon is right on how I approached it. I just based the fix on the existing implementation of the sitemap links.

@mirumodapon
Copy link
Copy Markdown
Collaborator

Hi there,
for this PR, the main focus is to resolve the current bug. As for whether we should switch to useLocalePath, I think we can continue that discussion separately in a follow-up discussion or refactor.

Copy link
Copy Markdown
Collaborator

@mirumodapon mirumodapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirumodapon mirumodapon merged commit 494044b into COSCUP:main May 12, 2026
1 check failed
@harriebird
Copy link
Copy Markdown
Contributor Author

Thank you @mirumodapon! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants