Skip to content

Commit

Permalink
review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
mehulgoel873 committed Jan 7, 2025
1 parent fcfefca commit d6eda8a
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 18 deletions.
2 changes: 1 addition & 1 deletion rb_ws/src/buggy/buggy/controller/controller_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def odom_listener(self, msg : Odometry):
with self.lock:
self.odom = msg

def traj_listener(self, msg): #TYPE UNKOWN AS OF NOW?? CUSTOM TYPE WHEN #TODO: FIGURE OUT BEFORE MERGE
def traj_listener(self, msg):
'''
This is the subscriber that updates the buggies trajectory for navigation
'''
Expand Down
2 changes: 1 addition & 1 deletion rb_ws/src/buggy/buggy/simulator/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import numpy as np
import utm
sys.path.append("/rb_ws/src/buggy/buggy")
from util.util import Constants
from rb_ws.src.buggy.buggy.util.constants import Constants

class Simulator(Node):

Expand Down
File renamed without changes.
15 changes: 0 additions & 15 deletions rb_ws/src/buggy/buggy/util/pose.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,18 +201,3 @@ def __truediv__(self, other):
p2_mat = other.to_mat()

return Pose.from_mat(np.linalg.inv(p2_mat) @ p1_mat)


if __name__ == "__main__":
# TODO: again do we want example code in these classes
rospose = ROSPose()
rospose.position.x = 1
rospose.position.y = 2
rospose.position.z = 3
rospose.orientation.x = 0
rospose.orientation.y = 0
rospose.orientation.z = -0.061461
rospose.orientation.w = 0.9981095

pose = Pose.rospose_to_pose(rospose)
print(pose) # Pose(x=1, y=2, theta=-0.123)
2 changes: 1 addition & 1 deletion rb_ws/src/buggy/buggy/util/trajectory.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def __init__(self, json_filepath=None, positions = None, interpolator="CubicSpli
lon = waypoint["lon"]

# Convert to world coordinates
x, y, _, _ = utm.from_latlon(lat, lon) #TODO: Before Merging, make sure that we can do this nonlocalized
x, y, _, _ = utm.from_latlon(lat, lon)
positions.append([x, y])

positions = np.array(positions)
Expand Down

0 comments on commit d6eda8a

Please sign in to comment.