Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-for autonsystem and serial node #78

Merged
merged 1 commit into from
Apr 4, 2024
Merged

-for autonsystem and serial node #78

merged 1 commit into from
Apr 4, 2024

Conversation

Jackack
Copy link
Collaborator

@Jackack Jackack commented Apr 4, 2024

-use ros logging functions instead of print

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Describe the CHANGES, the REASONING, and BENEFITS of this PR.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

-use ros logging functions instead of print
Copy link
Collaborator

@mehulgoel873 mehulgoel873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mehulgoel873 mehulgoel873 merged commit 9ac503b into main Apr 4, 2024
3 checks passed
@mehulgoel873 mehulgoel873 deleted the log branch April 4, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants