Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

during rolls sanity check #52

Merged
merged 24 commits into from
Mar 19, 2024
Merged

during rolls sanity check #52

merged 24 commits into from
Mar 19, 2024

Conversation

TiaSinghania
Copy link
Collaborator

@TiaSinghania TiaSinghania commented Mar 15, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

added an additional node that reads covariance, filter-gps seperation (work in progress), imu overrange status and translates filter status flags to bit fields and error message strings displayed in foxglove

QA Instructions, Screenshots, Recordings

can test the existence of the fields in sim, will need real buggy data to test if the flags get tripped accurately

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: would need to test on real buggy data (to get location data, filter separation, covariance, etc.)
  • I need help with writing tests

@TiaSinghania TiaSinghania marked this pull request as ready for review March 17, 2024 17:31
Copy link
Collaborator

@Jackack Jackack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

rb_ws/src/buggy/scripts/auton/autonsystem.py Outdated Show resolved Hide resolved
@TiaSinghania TiaSinghania requested a review from Jackack March 19, 2024 00:41
@TiaSinghania TiaSinghania merged commit ce8eade into main Mar 19, 2024
3 checks passed
@TiaSinghania TiaSinghania deleted the sanity-check branch March 19, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants