-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auton overtake feature, as well as pylint fixes #39
Conversation
…ctory from __init__ parameter of trajectory.py
more pylint fixes pylint fixes for 2d sim and other existing modules pylint fixes yet again pylint fixes yet again #2
Due to my git rebase skill issue, the CI commit, which was merged into this branch from main, got rebased :/ A lot of the delta should be due to fixing pylint errors (trailing whitespace, import orders, etc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked offline about adding documentation (function headers/file headers/etc.) at a later point right? Since we're rushing this out for now?
Otherwise, please see comments. I'll run it once it's fixed on my computer to validate.
Please update a screenshot or description of what I should expect during testing in the appropriate location in the PR template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just please update the PR template as it includes information needed for people to actually PR this. Once that's updated, I will know how to run these tests and what I should expect.
Updated PR template, feel free to check out the demo ROSbag and/or testing this code for yourself. |
Tested this with a few scenarios on my own computer - looks good. |
Added exec permission to velocity_ui.py
added if statement for selecting velocity source in launch config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under pressure to approve, but looks good
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
To test auton overtaking in sim: run sim_2d_2buggies.launch
You will be able to visualize the movements of the 2 simulated buggies in Foxglove.
What you should see on the map visualization are 2 buggies. One will move faster and overtake another, staying 2 meters away at the closest.
Here's the ROSbag of the demo run: https://drive.google.com/file/d/1913GAiZg_PoAF8P0pv_pyOv-dJqz8pLd/view?usp=drive_link
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included