Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfered the trajectory passing in autonsystem to be handled by ros messages #100

Merged
merged 7 commits into from
Jun 28, 2024

Conversation

mehulgoel873
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Changes -- I created a pack and unpack function within the trajectory class that takes the positions and packs it into a ros msg that can be sent over ros topics.

The reasoning behind this is that this better separates the controller from the path planner to better reflect our software architecture and will make more sense overall.

The benefits behind this change is that the overall repository now has a chance for becoming cleaner and overall more likely to work.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

I ran the single and double version of the buggy sim, and the code seemed to be working.

  • [X ] Yes
  • [] No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

Copy link
Collaborator

@TiaSinghania TiaSinghania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the final version of the trajectory setup? It seems like the files are still as coupled as before, how does prompting the trajectory class to publish a new trajectory each tick different from just having it return the trajectory directly?

@mehulgoel873
Copy link
Collaborator Author

Is this the final version of the trajectory setup? It seems like the files are still as coupled as before, how does prompting the trajectory class to publish a new trajectory each tick different from just having it return the trajectory directly?

This is correct, I haven't decoupled the files in the autonsystem just yet. This requires recreating how we treat the controllers and path planners, which I wanted to make a separate task due to the behemoth that is. However, since now all the information passed between both the controller and path planner happens only through a ros topic, it should be relatively simple to separate both into different ros nodes.

@TiaSinghania TiaSinghania merged commit 817e005 into main Jun 28, 2024
3 checks passed
@TiaSinghania TiaSinghania deleted the mehulg/trajROSmsg branch June 28, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants