Raceday 2017 - Fully Autonomous #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still need to include documentation/explanation for it
reformatted docs
…U-Robotics-Club/RoboBuggy into vivaan-newAutonImplementation
VivaanBahl
commented
May 21, 2017
| @@ -0,0 +1,217 @@ | |||
| package listStuff; | |||
There was a problem hiding this comment.
@abhinavGirish I think you committed this by accident
VivaanBahl
commented
May 21, 2017
| @@ -32,6 +32,8 @@ | |||
| public static final boolean LOGGING = true; | |||
| public static final String LOG_FILE_LOCATION = "logs"; | |||
| public static final String LOG_FILE_NAME = "sensors"; | |||
| public static final double LATITUDE = 40.441670; | |||
There was a problem hiding this comment.
@abhinavGirish let's name this something better like INITIAL_POS_LAT and INITIAL_POS_LON
VivaanBahl
commented
May 21, 2017
|
|
||
| // Initialize Nodes | ||
| nodeList.add(new RobobuggyKFLocalizer(10, "Robobuggy KF Localizer", new LocTuple(40.441670, -79.9416362))); |
There was a problem hiding this comment.
@abhinavGirish I forgot about these constants, can you fix this?
VivaanBahl
commented
May 25, 2017
| private GpsMeasurement target; | ||
|
|
||
| // we only want to look at the next 10 waypoints as possible candidates | ||
| private final int wayPointLOOKAHEADMAX = 50; |
There was a problem hiding this comment.
Why isn't this static anymore @abhinavGirish? the naming is all weird now
…U-Robotics-Club/RoboBuggy into vivaan-newAutonImplementation
|
This is now approved and is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is effectively the code that ran on Raceday 2017 (save for a few minor details that will be pushed later)