BFD-3808: Pipeline submits its own per-dataset metrics to CloudWatch #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malessi
force-pushed
the
alessio/BFD-3808__dataset-metrics
branch
4 times, most recently
from
9b55e30 to
3231f1e
Compare
malessi
requested review from
mjburling,
dondevun and
aschey-forpeople
as code owners
malessi
force-pushed
the
alessio/BFD-3808__dataset-metrics
branch
from
3231f1e to
866f028
Compare
malessi
force-pushed
the
alessio/BFD-3808__dataset-metrics
branch
from
866f028 to
6346949
Compare
...-pipeline/bfd-pipeline-ccw-rif/src/main/java/gov/cms/bfd/pipeline/ccw/rif/CcwRifLoadJob.java
Outdated
Show resolved
Hide resolved
...-pipeline/bfd-pipeline-ccw-rif/src/main/java/gov/cms/bfd/pipeline/ccw/rif/CcwRifLoadJob.java
Outdated
Show resolved
Hide resolved
malessi
force-pushed
the
alessio/BFD-3808__dataset-metrics
branch
from
6346949 to
2d1f7bb
Compare
aschey-forpeople
previously approved these changes
Jan 22, 2025
… of dataset processing
malessi
force-pushed
the
alessio/BFD-3808__dataset-metrics
branch
from
935ca9f to
95b4aa8
Compare
...-pipeline/bfd-pipeline-ccw-rif/src/main/java/gov/cms/bfd/pipeline/ccw/rif/CcwRifLoadJob.java
Show resolved
Hide resolved
aschey-forpeople
approved these changes
Jan 24, 2025
dondevun
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3808
What Does This PR Do?
This PR introduces two new per-dataset, dimensioned CloudWatch Metrics. These new Metrics measure the total time it takes the CCW Pipeline to load an entire RIF dataset as well the active, cumulative time it takes to load. Of particular interest are the following Metrics:
CcwRifLoadJob.dataset_processing.total.maxCcwRifLoadJob.dataset_processing.active.durationThe first Metric measures the final, total time to load a given dataset and is submitted once only after the dataset is fully loaded. The second Metric is measured and submitted every minute during the processing of a dataset and actively measures the time the CCW Pipeline is taking to process a dataset. The former will be used in our Dashboards whereas the latter will be used to implement the
Time to ingest a weekly batch load once available in S3SLO Alarms.What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependenciesModifies any security controlsAdds new transmission or storage of dataAny other changes that could possibly affect security?I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
3808-testenvironment, introducing a synthetic and non-synthetic load in S3, and verifying that: