-
Notifications
You must be signed in to change notification settings - Fork 129
Remove implicit use of CRS in code base #1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
luseverin
wants to merge
40
commits into
develop
Choose a base branch
from
feature/remove_implicit_use_crs
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
657b612
Add function to test if lat and lon are in geographic coords
b594b7f
Add test for geographic coords in dist_to_coast
e36ded8
Add test for geographic coords in coord_on_land
dc78a13
Merge branch 'develop-white' into feature/remove_implicit_use_crs
b88ecc4
Switch branch feature/remove_implicite_use_crs to black format
96ede79
Merge branch 'develop-black' into feature/remove_implicit_use_crs
2bc5c6a
Merge branch 'develop' into feature/remove_implicit_use_crs
b139e8f
Merge branch 'develop' into feature/remove_implicit_use_crs
c8aac80
Merge branch 'develop' into feature/remove_implicit_use_crs
320d0f7
Extend allowed extent for geo coords
9ef7323
Modify allowed extents in geo_coords check function to allow for bounds
f27c4aa
Include possible wrong lat lon extension in error message
df439a5
Add check for geo coords in get_country_code
d3aea1e
Add test for geocoords in convert_wgs_to_utm
fb3cf7e
Update error message in coord_on_land
cf57963
Harmonize error messages
cb1e718
Adapt test get_country_geometries_fail
2a1f9b1
Check for geo coords in match_coordinates
322a9d3
Add check for lat in get_gridcellarea
60dc067
Modify check geo coords function to please linter
a0e02be
Add test for geo coords in calc of coriolis param
127d9cc
Add tests for check_if_geo_coords function
737fcd4
Merge branch 'develop' into feature/remove_implicit_use_crs
eca9f77
Incorporate suggestions from review 1
luseverin 99635bf
Start adapating match_coordinates function to other crs
a642c04
Add handling of unit in match_centroids
eea31cb
Rename deg to degrees
35f0f7f
Add function to infer unit of coordinates
782b53d
Use infer_unit_coords in match_centroids function
ffee7f8
Add tests for unit_infer and unit-adapted match_coordinates
61e7b0f
Make test_tack_land_params compliant with new requirement of geodetic…
ef250c4
Correct wrong is_geodetic crs attribute
bca6e3a
Add restriction for haversine with non-degree units
54e2f75
Finish adding test for handling of different units
63bf8b5
Add test invalid unit for match coords and docstrings
da1c965
Update docstrings
5d53512
Try to fix new linter issues
54c8565
Correct error in logger warning
e1c9633
Force check_antimeridian to False in distance euclidean if unit is no…
fbcb163
Remove outdated test for raise of ValueError when check_antimeridian …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.