Skip to content

Add section to let CMake manage the Kokkos dependency #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pzehner
Copy link
Member

@pzehner pzehner commented Feb 21, 2025

Add a section to integrate Kokkos with CMake FetchContent. The hybrid external/internal dependency code cannot be displayed due to insufficient space on the pages. Not a perfect solution, but it's aligned with the official documentation.

Preview:

Capture d’écran du 2025-04-30 20-28-11

@pzehner pzehner added the enhancement New feature or request label Feb 21, 2025
@pzehner pzehner self-assigned this Feb 21, 2025
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end I don't think we should go into the details of how to use FetchContent etc. This is largely opinionated. I would rather describe the package name, the targets and the components available. Similar to the Targets tab in https://conan.io/center/recipes/ginkgo. We can also mention that Kokkos supports being added as a subdirectory, this implies for example that Kokkos::kokkos also exists which is not obvious.

@pzehner
Copy link
Member Author

pzehner commented Mar 11, 2025

I don't know, I think it gives practical directions about "how to include Kokkos as a dependency to my project," which is unfortunately not trivial at this time.

You cannot simply do:

conan install kokkos

@pzehner
Copy link
Member Author

pzehner commented Apr 29, 2025

I could restore the page layout, but I cannot show the external/internal dependency approaches on the page, as it would take too much space. I just added a comment saying that it is possible. I think it's a start nevertheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants