data: option to loosen json data type validation #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to v1.0.212 the default behavior was to allow numbers and boolean values to be in quotes, which is technically a violation of the spec. This adds a new `LY_CTX_LOOSE_JSON_DATATYPES` context option which will restore the prior behavior when enabled. SONiC is using v1.0.73 currently and has a large installed base which may be in violation of the new behavior, so adding such a flag is required for this usecase. Signed-off-by: Brad House <[email protected]>
bradh352
force-pushed
the
loose_datatypes
branch
from
166a56b to
a74e422
Compare
bradh352
changed the title
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 7, 2025
libyang1 would treat "true" and true as identical, same with "1234" and 1234. We need to restore this behavior so we don't break users. Sent upstream here: CESNET/libyang#2344
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 8, 2025
libyang1 would treat "true" and true as identical, same with "1234" and 1234. We need to restore this behavior so we don't break users. Sent upstream here: CESNET/libyang#2344
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 9, 2025
libyang1 would treat "true" and true as identical, same with "1234" and 1234. We need to restore this behavior so we don't break users. Sent upstream here: CESNET/libyang#2344
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 9, 2025
libyang1 would treat "true" and true as identical, same with "1234" and 1234. We need to restore this behavior so we don't break users. Sent upstream here: CESNET/libyang#2344
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 11, 2025
libyang1 would treat "true" and true as identical, same with "1234" and 1234. We need to restore this behavior so we don't break users. Sent upstream here: CESNET/libyang#2344
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 11, 2025
libyang1 would treat "true" and true as identical, same with "1234" and 1234. We need to restore this behavior so we don't break users. Sent upstream here: CESNET/libyang#2344
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to v1.0.212 the default behavior was to allow numbers
and boolean values to be in quotes, which is technically a
violation of the spec.
This adds a new
LY_CTX_LOOSE_JSON_DATATYPEScontext optionwhich will restore the prior behavior when enabled.
SONiC is using v1.0.73 currently and has a large installed base which
may be in violation of the new behavior, so adding such a flag is
required for this usecase.
Signed-off-by: Brad House (@bradh352)