data: option to allow json int/bool as strings #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
force-pushed
the
json_strings
branch
from
ca54ed6 to
b829165
Compare
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
force-pushed
the
json_strings
branch
from
b829165 to
c249839
Compare
|
CESNET/libyang#2344 has now been merged, just forced a rebuild of this to show tests pass. |
|
I guess it must be pulling from master instead of devel when building C libyang .... so still failing |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 17, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 20, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 20, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 21, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 28, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 3, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 4, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 3, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 3, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 20, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 22, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 24, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 13, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 13, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 13, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 13, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 13, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
|
@rjarry can you review, approve, and merge? |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 14, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 15, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 15, 2025
CESNET/libyang-python#134 needed for backwards compatibility for existing configurations.
|
@rjarry @samuel-gauthier any chance one of you can review? |
|
Is the feature available in a public release of libyang? If so, please change the minimum required version here: Line 9 in 3072af0 Otherwise we need to wait for a release. |
|
Yes, available as of the official 3.12.2 release. I'll update this PR with that, but the other PR I have open I can't really update that to without conflict. Both depend on the same 3.12.2 however (technically, it was introduced in the 3.7 series but no official release was made for those). |
bradh352
force-pushed
the
json_strings
branch
2 times, most recently
from
a212ca0 to
c127f99
Compare
rjarry
reviewed
Jun 30, 2025
cffi/source.c
Outdated
Comment on lines
9
to
10
| #if (LY_PROJ_VERSION_MAJOR != 3 || LY_PROJ_VERSION_MINOR < 12) | ||
| #error "This version of libyang bindings only works with libyang 3.12+" |
There was a problem hiding this comment.
LY_PROJ_VERSION_* constants are only recent. Could you keep the test on LY_VERSION_* so that error messages are useful when building with ancient libyang versions?
Also, as you said, your series depends on CESNET/libyang@2d477f52d5c8 (I may be wrong about the exact SOVERSION, please do verify my claim).
Even if it wasn't an official tagged release, you can still depend on that specific version.
#if (LY_VERSION_MAJOR != 3 || LY_VERSION_MINOR < 8)
#error "This version of libyang bindings only works with libyang 3.8+"
#endif
bradh352
force-pushed
the
json_strings
branch
3 times, most recently
from
810f744 to
e3467e6
Compare
Depends on CESNET/libyang#2344 Add support for new option to python bindings. Signed-off-by: Brad House <[email protected]>
|
@rjarry sorry for the delay, got busy. Fixed the version check as per your request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on libyang 3.12.2 or higher
Add support for new option to python bindings.