Parallel tests #475
Merged
Parallel tests #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll be needing some per-test parameters to be auto-managed by CMake, and doing that is very easy once there's a simple wrapper which adds tests one at a time. As a bonus, this patch already makes the definition of wrapped functions more readable.
This fixes parallel test execution. Without this patch, parallel runs were dying all the time for me (I'm using -j16 because that's what I have even on this laptop). This patch is the reason why I was converting the test suite to use one CMake function call per test.
...to make sure that we catch any possible hardcoded ports in future.
Roytak
approved these changes
Apr 8, 2024
|
The test suite could really use some updating and that is something I plan to do in the future. I think this is a good step forward and a nice change. The CMake looks way cleaner this way. |
michalvasko
approved these changes
Apr 9, 2024
|
Okay, thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests in parallel was broken because these files all had some hard-coded port numbers. Some of these port numbers were OK, others were overlapping. Let's fix that by letting CMake manage these port numbers. However, to do that, one has to first convert the CMake setup to a "more idiomatic" approach with one function call per test. As a bonus, this gets rid of some "random variables" and the final test declarations are, hopefully, a bit easier to read. See the individual commits for descriptions.