Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB: fix unpacking of fulltext filters in for loop #29

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

dbnk0
Copy link
Collaborator

@dbnk0 dbnk0 commented Feb 24, 2025

Fixes error:

...
File ".../dp3/database/snapshots.py", line 249, in _prepare_latest_query
    for attr, attr_filter in fulltext_filters:
ValueError: too many values to unpack (expected 2)

thrown at GET /entity/{etype}/get and GET /entity/{etype}/count endpoints when fulltext_filters are not empty.

Most likely just a missed replacement from d8ae2b4.

Fixes error:
```
...
File ".../dp3/database/snapshots.py", line 249, in _prepare_latest_query
    for attr, attr_filter in fulltext_filters:
ValueError: too many values to unpack (expected 2)
```
thrown at `GET /entity/{etype}/get` and `GET /entity/{etype}/count`
endpoints when `fulltext_filters` are not empty.

Most likely just a missed replacement from d8ae2b4.
Copy link
Collaborator

@xsedla1o xsedla1o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@xsedla1o xsedla1o merged commit 52e2515 into master Feb 25, 2025
4 checks passed
@dbnk0 dbnk0 deleted the fix_fulltext_filters_unpack branch February 25, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants