-
Notifications
You must be signed in to change notification settings - Fork 8
[1주차] 남기림 과제 제출합니다. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GirimNam
wants to merge
8
commits into
CEOS-Developers:master
Choose a base branch
from
GirimNam:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fb8e16a
first commit
a1e616c
Merge remote-tracking branch 'upstream/master'
0f59736
feat: vite.config.js 파일 추가
c4fe0e0
feat: 날짜 이동 버튼 추가
11ac082
feat: 배경상수 전역 범위 변경
df4a03a
feat: date()를 temporal()로 변경
2546471
fix: localStorage() 로드 값 변경
1b71b1f
fix: 1주차 코드리뷰 반영
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
| lerna-debug.log* | ||
|
|
||
| node_modules | ||
| dist | ||
| dist-ssr | ||
| *.local | ||
|
|
||
| # Editor directories and files | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| .DS_Store | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>todo</title> | ||
| </head> | ||
| <body> | ||
| <div id="app"> | ||
| <header> | ||
| <h1>TO DO LIST</h1> | ||
|
|
||
| <div class="date-btns"> | ||
| <button id="prev">◀</button> | ||
| <h2 id="date"></h2> | ||
| <button id="next">▶</button> | ||
| </div> | ||
| </header> | ||
|
|
||
| <main> | ||
| <section class="inputlist"> | ||
| <form> | ||
| <input | ||
| type="text" | ||
| id="todo-input" | ||
| placeholder="할 일을 입력하세요." | ||
| /> | ||
| <button id="add">추가</button> | ||
| </form> | ||
|
|
||
| <div>남은 TO DO의 개수: <span class="count">0</span>개</div> | ||
| </section> | ||
|
|
||
| <section> | ||
| <ul id="todo-list"></ul> | ||
| </section> | ||
| </main> | ||
|
Comment on lines
+10
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| </div> | ||
|
|
||
| <script type="module" src="/src/main.js"></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/@js-temporal/polyfill"></script> | ||
| </body> | ||
| </html> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI 상에서 다른 요소와 같이 해당 텍스트도 중앙 정렬해주셔도 좋을 것 같습니다.