fixed gfx_AllocSprite return value bug #659
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZERICO2005
force-pushed
the
gfx_alloc_sprite_bug
branch
from
ccdf6f7 to
8d8f37d
Compare
ZERICO2005
had a problem deploying
to
Autotester
GitHub Actions
Failure
ZERICO2005
had a problem deploying
to
Autotester
GitHub Actions
Failure
runer112
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERGE #657 BEFORE THIS!!!
fixes #658
gfx_AllocSprite made an invalid assumption that the allocation routine would preserve the stack parameters. allocation routines such as
__simple_mallocdestroy the stack parameter, which can cause a returned non-NULL pointer to be off by one. This is especially problematic when this off-by-one pointer has to be freed.The bug with the
width * height == 0case is assumed to be undefined behavior, since the sprite routines don't handle this case either.