Skip to content

feat: Adding Pregnancy Summary Organizer - #1666

Open
laura-puerto-skylight wants to merge 4 commits into
mainfrom
laura/1498-pregnancy-organizer
Open

feat: Adding Pregnancy Summary Organizer#1666
laura-puerto-skylight wants to merge 4 commits into
mainfrom
laura/1498-pregnancy-organizer

Conversation

@laura-puerto-skylight

Copy link
Copy Markdown
Collaborator

Summary

Initial draft of pregnancy organizer UI (History of Pregnancies):
image

Related Issue

Fixes #1498

Acceptance Criteria

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@laura-puerto-skylight
laura-puerto-skylight requested a review from a team as a code owner July 28, 2026 22:10
@laura-puerto-skylight
laura-puerto-skylight requested review from angelathe, austin-hall-skylight, echinelo-skylight and vochaparro2 and removed request for a team July 28, 2026 22:10
@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.79%. Comparing base (25b2110) to head (23d6004).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
- Coverage   84.81%   84.79%   -0.02%     
==========================================
  Files         264      255       -9     
  Lines       11363    10886     -477     
  Branches     1512     1489      -23     
==========================================
- Hits         9637     9231     -406     
+ Misses       1718     1647      -71     
  Partials        8        8              
Flag Coverage Δ
ecr-viewer 91.21% <100.00%> (+0.01%) ⬆️
ingestion 61.49% <ø> (ø)
message-parser 89.64% <ø> (ø)
orchestration 85.90% <ø> (ø)
trigger-code-reference ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@echinelo-skylight echinelo-skylight left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laura-puerto-skylight let's update two of the column names as "Outcome" and "Count".

Also for each type of outcome, does the data come in as "[#] Pregnancies" or is the bracketed hashtag placeholder text? If it's not placeholder text, then lets only display the outcome name like "Pregnancies" in the screenshot provided below.

Image

@laura-puerto-skylight

Copy link
Copy Markdown
Collaborator Author

Also for each type of outcome, does the data come in as "[#] Pregnancies" or is the bracketed hashtag placeholder text? If it's not placeholder text, then lets only display the outcome name like "Pregnancies" in the screenshot provided below.

@echinelo-skylight The text being displayed is the text that corresponds to the code for each of those so [#] Pregnancies is the display name for LOINC code 11996-6. We usually don't modify those display names but I could try to remove [#] if its present in the string. What do you think? @angelathe do you have thoughts on this?

@angelathe

Copy link
Copy Markdown
Collaborator

Hmm I'd defer to Chinelo on this, but my first instinct is not to modify the display names because those are the official LOINC codes

@echinelo-skylight

echinelo-skylight commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Hmm I'd defer to Chinelo on this, but my first instinct is not to modify the display names because those are the official LOINC codes

Thanks @angelathe and @laura-puerto-skylight it's really helpful insight. I agree on not modifying the display names since they are the official LOINC codes. I learned something new 🤓. Let's leave them as is and move the code forward.

@echinelo-skylight
echinelo-skylight self-requested a review July 31, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.1 Spec - Pregnancy Data - Pregnancy Organizer

4 participants