[FEAT] Add `bitstream` module in `lib_ccxr` #1649

mrswastik-robot · 2024-12-25T13:02:05Z

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This PR migrates the bitstream functionality from C to Rust while maintaining backward compatibility by creating a new Rust implementation in lib_ccxr/src/common/bitstream.rs and connecting it to the existing C code through FFI bindings.

prateekmedia · 2024-12-26T18:58:56Z

src/lib_ccx/cc_bitstream.h

@@ -25,6 +24,9 @@ struct bitstream
 	// increased by the calling function, or not.
 	unsigned char *_i_pos;
 	int _i_bpos;
+#ifndef DISABLE_RUST
+	void *rust_bs;  // Pointer to Rust's Bitstream struct


Could we construct / deconstruct the struct when passing to rust instead of storing a different pointer?

There are other files, where you can see the to_ctype()

yaa surely, this should be a better approach rather than having to maintain two structures. I will try to fix it in my next commit

@prateekmedia , I have made changes in the bitstream.rs file , can you please review it now

will check this.

Migration module changes

Minor Formatting Issue

ccextractor-bot · 2025-06-14T20:37:15Z

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 5b327c7...:

Report Name	Tests Passed
Broken	12/13
CEA-708	5/14
DVB	7/7
DVD	0/3
DVR-MS	2/2
General	10/27
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	82/86
Teletext	21/21
WTV	12/13
XDS	17/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

ccextractor --out=sami --latin1 --autoprogram 5b4e0a6034..., Last passed: Test 5729
ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed: Test 5729
ccextractor --service 1 --out=txt f17524b53f..., Last passed: Test 5729
ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed: Test 5729
ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed: Test 5729
ccextractor --service 1 --out=sami da904de35d..., Last passed: Test 5729
ccextractor --service 1 --out=ttxt da904de35d..., Last passed: Test 5729
ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed: Test 5729
ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed: Test 5729
ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed: Test 5729
ccextractor --out=srt --latin1 --autoprogram 56c9f34548..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 d037c7509e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla c41f73056a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 70000200c0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 15feae9133..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 15feae9133..., Last passed: Test 5729
ccextractor --out=spupng c83f765c66..., Last passed: Test 5729
ccextractor --in=ps e9b9008fdf..., Last passed: Test 5729
ccextractor --in=es dc7169d7c4..., Last passed: Test 5729
ccextractor --xmltv --out=null 96efd279cf..., Last passed: Test 5729
ccextractor --out=srt --latin1 f23a544ba8..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla d037c7509e..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e..., Last passed: Test 5729
ccextractor --autoprogram --out=smptett --latin1 --ucla e274a73653..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b22260d065..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --xds --ucla c813e713a0..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla c813e713a0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7d2730d38e..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 7d2730d38e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds c8dc039a88..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla c8dc039a88..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 53339f3455..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 88cd42b89a..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 88cd42b89a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 7f41299cc7..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed: Test 5729

Congratulations: Merging this PR would fix the following tests:

ccextractor --autoprogram --out=srt --latin1 1d9731bd80..., Last passed: Test 5729
ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 7236304cfc..., Last passed: Test 5729
ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed: Test 5729
ccextractor --out=srt --latin1 06b3a9237d..., Last passed: Test 5729
ccextractor --out=srt --latin1 83f8cceb74..., Last passed: Test 5729
ccextractor --out=srt --latin1 611b4a9235..., Last passed: Test 5729
ccextractor --out=srt --latin1 b46e9e8e3f..., Last passed: Test 5729
ccextractor --out=srt --latin1 89e417e622..., Last passed: Test 5729
ccextractor --out=srt --latin1 d59eadc4ed..., Last passed: Test 5729
ccextractor --out=srt --latin1 4d4e938ef6..., Last passed: Test 5729
ccextractor --service 1 --out=txt da904de35d..., Last passed: Test 5729
ccextractor --service 1 --out=txt 80848c45f8..., Last passed: Test 5729
ccextractor --service 1 --out=srt da904de35d..., Last passed: Test 5729
ccextractor --service all da904de35d..., Last passed: Test 5729
ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 1020459a86..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Test 5729
ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 85271be4d2..., Last passed: Test 5729
ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed: Test 5729
ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed: Test 5729
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 acf871cbfd..., Last passed: Test 5729
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 5cbb21adb6..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 9a496d3828..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 c032183ef0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 6dc772d881..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla adce82fd39..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla ab9cf8cfad..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 5d3a29f9f8..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 c41f73056a..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --sentencecap c032183ef0..., Last passed: Test 5729
ccextractor --autoprogram --out=bin --latin1 c032183ef0..., Last passed: Test 5729
ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Test 5729
ccextractor --hauppauge --autoprogram --out=srt --latin1 a03b5b2a56..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --hauppauge --latin1 553d78e755..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --hauppauge --ucla --latin1 553d78e755..., Last passed: Test 5729
ccextractor --in=mp4 --out=srt --latin1 b2771c84c2..., Last passed: Test 5729
ccextractor --in=mp4 --out=srt --latin1 5df914ce77..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --bom --latin1 8849331dda..., Last passed: Test 5729
ccextractor --mp4vidtrack --autoprogram --out=ttxt --latin1 adc0a818c3..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 08bdf0e2c1..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 bee139671a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 3842d00925..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 80af83c038..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 837b02f722..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 41dab6b2a7..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 4b117b4d66..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 26ee6add4d..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds fca0dce412..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --output-field 1 a65d39ccb3..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --output-field 2 a65d39ccb3..., Last passed: Test 5729
ccextractor --autoprogram c83f765c66..., Last passed: Test 5729
ccextractor --service 1 c83f765c66..., Last passed: Test 5729
ccextractor --in=ts c83f765c66..., Last passed: Test 5729
ccextractor --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --out=sami c83f765c66..., Last passed: Test 5729
ccextractor --out=dvdraw c83f765c66..., Last passed: Test 5729
ccextractor --out=txt c83f765c66..., Last passed: Test 5729
ccextractor --out=ttxt c83f765c66..., Last passed: Test 5729
ccextractor --out=smptett c83f765c66..., Last passed: Test 5729
ccextractor --goptime c83f765c66..., Last passed: Test 5729
ccextractor --no-goptime c83f765c66..., Last passed: Test 5729
ccextractor --fixpadding c83f765c66..., Last passed: Test 5729
ccextractor --90090 c83f765c66..., Last passed: Test 5729
ccextractor --myth c83f765c66..., Last passed: Test 5729
ccextractor --program-number 1 c83f765c66..., Last passed: Test 5729
ccextractor --datapid 256 c83f765c66..., Last passed: Test 5729
ccextractor --datastreamtype 2 c83f765c66..., Last passed: Test 5729
ccextractor --datastreamtype 2 --streamtype 2 c83f765c66..., Last passed: Test 5729
ccextractor --no-autotimeref c83f765c66..., Last passed: Test 5729
ccextractor --bom c83f765c66..., Last passed: Test 5729
ccextractor --no-bom c83f765c66..., Last passed: Test 5729
ccextractor --unicode c83f765c66..., Last passed: Test 5729
ccextractor --utf8 c83f765c66..., Last passed: Test 5729
ccextractor --latin1 c83f765c66..., Last passed: Test 5729
ccextractor --no-fontcolor c83f765c66..., Last passed: Test 5729
ccextractor --no-typesetting c83f765c66..., Last passed: Test 5729
ccextractor --trim c83f765c66..., Last passed: Test 5729
ccextractor --sentencecap c83f765c66..., Last passed: Test 5729
ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66..., Last passed: Test 5729
ccextractor --unixts 5 --out=txt c83f765c66..., Last passed: Test 5729
ccextractor --out=txt --datets c83f765c66..., Last passed: Test 5729
ccextractor --out=txt --sects c83f765c66..., Last passed: Test 5729
ccextractor --out=txt --lf c83f765c66..., Last passed: Test 5729
ccextractor --autodash --trim c83f765c66..., Last passed: Test 5729
ccextractor --bufferinput c83f765c66..., Last passed: Test 5729
ccextractor --no-bufferinput c83f765c66..., Last passed: Test 5729
ccextractor --buffersize 1M c83f765c66..., Last passed: Test 5729
ccextractor --dru c83f765c66..., Last passed: Test 5729
ccextractor --no-rollup c83f765c66..., Last passed: Test 5729
ccextractor --ru1 c83f765c66..., Last passed: Test 5729
ccextractor --ru2 c83f765c66..., Last passed: Test 5729
ccextractor --ru3 c83f765c66..., Last passed: Test 5729
ccextractor --delay 200 c83f765c66..., Last passed: Test 5729
ccextractor --startat 4 --endat 7 c83f765c66..., Last passed: Test 5729
ccextractor --no-codec dvbsub c83f765c66..., Last passed: Test 5729
ccextractor --debug --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --608 --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --708 --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --goppts --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --xdsdebug --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --vides --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --cbraw --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --no-sync --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --fullbin --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --parsedebug --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --parsePAT --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --parsePMT --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --investigate-packets --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --in=asf 6395b281ad..., Last passed: Test 5729
ccextractor --in=wtv b46e9e8e3f..., Last passed: Test 5729
ccextractor --in=bin 988d4e8bba..., Last passed: Test 5729
ccextractor --in=raw fb79021542..., Last passed: Test 5729
ccextractor --in=mp4 b2771c84c2..., Last passed: Test 5729
ccextractor --mp4vidtrack 5df914ce77..., Last passed: Test 5729
ccextractor --wtvconvertfix acf871cbfd..., Last passed: Test 5729
ccextractor --wtvmpeg2 10f0f77cf4..., Last passed: Test 5729
ccextractor --hauppauge d6df1b227a..., Last passed: Test 5729
ccextractor --codec dvbsub --out=spupng 85271be4d2..., Last passed: Test 5729
ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5729
ccextractor --endcreditsforatleast 3 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5729
ccextractor --endcreditsforatmost 2 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5729
ccextractor --tpage 801 4e56e88ba4..., Last passed: Test 5729
ccextractor --tverbose 4e56e88ba4..., Last passed: Test 5729
ccextractor --teletext 4e56e88ba4..., Last passed: Test 5729
ccextractor --out=txt --ucla c83f765c66..., Last passed: Test 5729
ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 4e56e88ba4..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 b236a0590b..., Last passed: Test 5729
ccextractor --out=srt --latin1 97cc394d87..., Last passed: Test 5729
ccextractor --out=srt --latin1 10f0f77cf4..., Last passed: Test 5729
ccextractor --out=srt --latin1 df3b4d62d3..., Last passed: Test 5729
ccextractor --out=srt --latin1 d7e7dbdf68..., Last passed: Test 5729
ccextractor --out=srt --latin1 76734ac4a7..., Last passed: Test 5729
ccextractor --out=srt --latin1 c791382c94..., Last passed: Test 5729
ccextractor --out=srt --latin1 f673b2f916..., Last passed: Test 5729
ccextractor --out=srt --latin1 da75bdee47..., Last passed: Test 5729
ccextractor --out=srt --latin1 bd6f33a669..., Last passed: Test 5729
ccextractor --out=srt --latin1 0e5e6b26be..., Last passed: Test 5729
ccextractor --out=srt --latin1 a226cc302d..., Last passed: Test 5729
ccextractor --out=srt --latin1 ae6327683e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 725a49f871..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 27fab4dbb6..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 27fab4dbb6..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds bbd5bb52fc..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla bbd5bb52fc..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b992e0cccb..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds d0291cdcf6..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 53339f3455..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 83b03036a2..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 83b03036a2..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7d3f25c32c..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds f41d4c29a1..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla f41d4c29a1..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --output-field 2 --ucla 88cd42b89a..., Last passed: Test 5729

Check the result page for more info.

ccextractor-bot · 2025-06-14T21:27:14Z

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 407d0f4...:

Report Name	Tests Passed
Broken	11/13
CEA-708	6/14
DVB	2/7
DVD	0/3
DVR-MS	2/2
General	9/27
Hauppage	1/3
MP4	3/3
NoCC	10/10
Options	78/86
Teletext	4/21
WTV	10/13
XDS	14/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

ccextractor --out=sami --latin1 --autoprogram 5b4e0a6034..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 7236304cfc..., Last passed: Test 5729
ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed: Test 5729
ccextractor --service 1 --out=txt f17524b53f..., Last passed: Test 5729
ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed: Test 5729
ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed: Test 5729
ccextractor --service 1 --out=ttxt da904de35d..., Last passed: Test 5729
ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed: Test 5729
ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed: Test 5729
ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Test 5729
ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 85271be4d2..., Last passed: Test 5729
ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed: Test 5729
ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 5ae2007a79..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 1e44efd810..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 add511677c..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 9a496d3828..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 e9b9008fdf..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 c032183ef0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 27e46255f0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 d037c7509e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 1974a299f0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 b22260d065..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla c41f73056a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 5d3a29f9f8..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 70000200c0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 95dd33c6f1..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 01509e4d27..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 15feae9133..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 5d3a29f9f8..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --hauppauge --latin1 553d78e755..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --hauppauge --ucla --latin1 553d78e755..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --output-field 1 a65d39ccb3..., Last passed: Test 5729
ccextractor --out=ttxt c83f765c66..., Last passed: Test 5729
ccextractor --out=spupng c83f765c66..., Last passed: Test 5729
ccextractor --goptime c83f765c66..., Last passed: Test 5729
ccextractor --unicode c83f765c66..., Last passed: Test 5729
ccextractor --in=ps e9b9008fdf..., Last passed: Test 5729
ccextractor --in=es dc7169d7c4..., Last passed: Test 5729
ccextractor --xmltv --out=null 96efd279cf..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 b236a0590b..., Last passed: Test 5729
ccextractor --out=srt --latin1 f23a544ba8..., Last passed: Test 5729
ccextractor --out=srt --latin1 10f0f77cf4..., Last passed: Test 5729
ccextractor --out=srt --latin1 df3b4d62d3..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla d037c7509e..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e..., Last passed: Test 5729
ccextractor --autoprogram --out=smptett --latin1 --ucla e274a73653..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla e274a73653..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b22260d065..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --xds --ucla c813e713a0..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla c813e713a0..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 27fab4dbb6..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 27fab4dbb6..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds bbd5bb52fc..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla bbd5bb52fc..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 7d2730d38e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds c8dc039a88..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla c8dc039a88..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7d3f25c32c..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 88cd42b89a..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 88cd42b89a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 0069dffd21..., Last passed: Test 5729

Congratulations: Merging this PR would fix the following tests:

ccextractor --autoprogram --out=srt --latin1 1d9731bd80..., Last passed: Test 5729
ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b..., Last passed: Test 5729
ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed: Test 5729
ccextractor --out=srt --latin1 06b3a9237d..., Last passed: Test 5729
ccextractor --out=srt --latin1 83f8cceb74..., Last passed: Test 5729
ccextractor --out=srt --latin1 611b4a9235..., Last passed: Test 5729
ccextractor --out=srt --latin1 b46e9e8e3f..., Last passed: Test 5729
ccextractor --out=srt --latin1 89e417e622..., Last passed: Test 5729
ccextractor --out=srt --latin1 d59eadc4ed..., Last passed: Test 5729
ccextractor --out=srt --latin1 4d4e938ef6..., Last passed: Test 5729
ccextractor --service 1 --out=txt da904de35d..., Last passed: Test 5729
ccextractor --service 1 --out=txt 80848c45f8..., Last passed: Test 5729
ccextractor --service 1 --out=srt da904de35d..., Last passed: Test 5729
ccextractor --service 1 --out=sami da904de35d..., Last passed: Test 5729
ccextractor --service all da904de35d..., Last passed: Test 5729
ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 1020459a86..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed: Test 5729
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 acf871cbfd..., Last passed: Test 5729
ccextractor --wtvconvertfix --autoprogram --out=srt --latin1 5cbb21adb6..., Last passed: Test 5729
ccextractor --out=srt --latin1 --autoprogram 56c9f34548..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 6dc772d881..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla adce82fd39..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla 15feae9133..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla ab9cf8cfad..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --output-field 2 c41f73056a..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --sentencecap c032183ef0..., Last passed: Test 5729
ccextractor --autoprogram --out=bin --latin1 c032183ef0..., Last passed: Test 5729
ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Test 5729
ccextractor --hauppauge --autoprogram --out=srt --latin1 a03b5b2a56..., Last passed: Test 5729
ccextractor --in=mp4 --out=srt --latin1 b2771c84c2..., Last passed: Test 5729
ccextractor --in=mp4 --out=srt --latin1 5df914ce77..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --bom --latin1 8849331dda..., Last passed: Test 5729
ccextractor --mp4vidtrack --autoprogram --out=ttxt --latin1 adc0a818c3..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 08bdf0e2c1..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 bee139671a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 3842d00925..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 80af83c038..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 837b02f722..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 41dab6b2a7..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 4b117b4d66..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 26ee6add4d..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds fca0dce412..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --output-field 2 a65d39ccb3..., Last passed: Test 5729
ccextractor --autoprogram c83f765c66..., Last passed: Test 5729
ccextractor --service 1 c83f765c66..., Last passed: Test 5729
ccextractor --in=ts c83f765c66..., Last passed: Test 5729
ccextractor --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --out=sami c83f765c66..., Last passed: Test 5729
ccextractor --out=dvdraw c83f765c66..., Last passed: Test 5729
ccextractor --out=txt c83f765c66..., Last passed: Test 5729
ccextractor --out=smptett c83f765c66..., Last passed: Test 5729
ccextractor --no-goptime c83f765c66..., Last passed: Test 5729
ccextractor --fixpadding c83f765c66..., Last passed: Test 5729
ccextractor --90090 c83f765c66..., Last passed: Test 5729
ccextractor --myth c83f765c66..., Last passed: Test 5729
ccextractor --program-number 1 c83f765c66..., Last passed: Test 5729
ccextractor --datapid 256 c83f765c66..., Last passed: Test 5729
ccextractor --datastreamtype 2 c83f765c66..., Last passed: Test 5729
ccextractor --datastreamtype 2 --streamtype 2 c83f765c66..., Last passed: Test 5729
ccextractor --no-autotimeref c83f765c66..., Last passed: Test 5729
ccextractor --bom c83f765c66..., Last passed: Test 5729
ccextractor --no-bom c83f765c66..., Last passed: Test 5729
ccextractor --utf8 c83f765c66..., Last passed: Test 5729
ccextractor --latin1 c83f765c66..., Last passed: Test 5729
ccextractor --no-fontcolor c83f765c66..., Last passed: Test 5729
ccextractor --no-typesetting c83f765c66..., Last passed: Test 5729
ccextractor --trim c83f765c66..., Last passed: Test 5729
ccextractor --sentencecap c83f765c66..., Last passed: Test 5729
ccextractor --capfile /repository/Dictionary/MattS_dictionary.txt c83f765c66..., Last passed: Test 5729
ccextractor --unixts 5 --out=txt c83f765c66..., Last passed: Test 5729
ccextractor --out=txt --datets c83f765c66..., Last passed: Test 5729
ccextractor --out=txt --sects c83f765c66..., Last passed: Test 5729
ccextractor --out=txt --lf c83f765c66..., Last passed: Test 5729
ccextractor --autodash --trim c83f765c66..., Last passed: Test 5729
ccextractor --bufferinput c83f765c66..., Last passed: Test 5729
ccextractor --no-bufferinput c83f765c66..., Last passed: Test 5729
ccextractor --buffersize 1M c83f765c66..., Last passed: Test 5729
ccextractor --dru c83f765c66..., Last passed: Test 5729
ccextractor --no-rollup c83f765c66..., Last passed: Test 5729
ccextractor --ru1 c83f765c66..., Last passed: Test 5729
ccextractor --ru2 c83f765c66..., Last passed: Test 5729
ccextractor --ru3 c83f765c66..., Last passed: Test 5729
ccextractor --delay 200 c83f765c66..., Last passed: Test 5729
ccextractor --startat 4 --endat 7 c83f765c66..., Last passed: Test 5729
ccextractor --no-codec dvbsub c83f765c66..., Last passed: Test 5729
ccextractor --debug --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --608 --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --708 --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --goppts --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --xdsdebug --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --vides --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --cbraw --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --no-sync --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --fullbin --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --parsedebug --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --parsePAT --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --parsePMT --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --investigate-packets --out=srt c83f765c66..., Last passed: Test 5729
ccextractor --in=asf 6395b281ad..., Last passed: Test 5729
ccextractor --in=wtv b46e9e8e3f..., Last passed: Test 5729
ccextractor --in=bin 988d4e8bba..., Last passed: Test 5729
ccextractor --in=raw fb79021542..., Last passed: Test 5729
ccextractor --in=mp4 b2771c84c2..., Last passed: Test 5729
ccextractor --mp4vidtrack 5df914ce77..., Last passed: Test 5729
ccextractor --wtvconvertfix acf871cbfd..., Last passed: Test 5729
ccextractor --wtvmpeg2 10f0f77cf4..., Last passed: Test 5729
ccextractor --hauppauge d6df1b227a..., Last passed: Test 5729
ccextractor --codec dvbsub --out=spupng 85271be4d2..., Last passed: Test 5729
ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Test 5729
ccextractor --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5729
ccextractor --endcreditsforatleast 3 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5729
ccextractor --endcreditsforatmost 2 --endcreditstext "CCextractor Ends crdit Testing" addf5e2fc9..., Last passed: Test 5729
ccextractor --tpage 801 4e56e88ba4..., Last passed: Test 5729
ccextractor --tverbose 4e56e88ba4..., Last passed: Test 5729
ccextractor --teletext 4e56e88ba4..., Last passed: Test 5729
ccextractor --out=txt --ucla c83f765c66..., Last passed: Test 5729
ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 4e56e88ba4..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9..., Last passed: Test 5729
ccextractor --out=srt --latin1 97cc394d87..., Last passed: Test 5729
ccextractor --out=srt --latin1 d7e7dbdf68..., Last passed: Test 5729
ccextractor --out=srt --latin1 76734ac4a7..., Last passed: Test 5729
ccextractor --out=srt --latin1 c791382c94..., Last passed: Test 5729
ccextractor --out=srt --latin1 f673b2f916..., Last passed: Test 5729
ccextractor --out=srt --latin1 da75bdee47..., Last passed: Test 5729
ccextractor --out=srt --latin1 bd6f33a669..., Last passed: Test 5729
ccextractor --out=srt --latin1 0e5e6b26be..., Last passed: Test 5729
ccextractor --out=srt --latin1 a226cc302d..., Last passed: Test 5729
ccextractor --out=srt --latin1 ae6327683e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 725a49f871..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds b992e0cccb..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds d0291cdcf6..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 7d2730d38e..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 53339f3455..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 53339f3455..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 83b03036a2..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 83b03036a2..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds f41d4c29a1..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla f41d4c29a1..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --output-field 2 --ucla 88cd42b89a..., Last passed: Test 5729
ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7..., Last passed: Test 5729
ccextractor --autoprogram --out=srt --latin1 --ucla 7f41299cc7..., Last passed: Test 5729

Check the result page for more info.

Copilot

Pull Request Overview

This PR adds a new bitstream module implemented in Rust and connects it to the existing C code via FFI.

Introduces Rust-side bitstream functions and exposes them through the C wrapper
Updates C bitstream implementation to delegate to Rust when DISABLE_RUST is not defined
Adjusts tests and build configuration to include the new module

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/rust/wrapper.h	Includes the C header for bitstream to expose FFI
src/rust/src/libccxr_exports/mod.rs	Registers the `bitstream` export module
src/rust/lib_ccxr/src/util/bits.rs	Refactors parity tests to use `assert!`
src/rust/lib_ccxr/src/common/mod.rs	Adds `bitstream` to the common mod exports
src/rust/build.rs	Links the `bitstream` library into the build script
src/lib_ccx/cc_bitstream.c	Wraps the C implementation to call into Rust

Comments suppressed due to low confidence (3)

src/lib_ccx/cc_bitstream.c:238

The function signature returns unsigned char * but the Rust FFI ccxr_next_bytes exports a const uint8_t *. Consider updating this to const unsigned char * to preserve the const qualifier and avoid discarding it.

		bstr->bpos = 8;

src/rust/wrapper.h:14

wrapper.h includes the C header for bitstream but does not declare the extern ccxr_* functions provided by the Rust bitstream module, so consumers won’t see the Rust FFI symbols. Consider adding extern declarations for each ccxr_* function in this header.

#include "../lib_ccx/cc_bitstream.h"

src/rust/build.rs:30

The bitstream entry may not match the actual C library name produced (likely something like ccx_bitstream or part of the existing ccx library), which could cause linker errors. Verify that the linked library name matches the compiled archive.

        "bitstream",

src/rust/lib_ccxr/src/util/bits.rs

src/rust/lib_ccxr/src/common/mod.rs

mrswastik-robot added 4 commits December 25, 2024 18:16

feat: Add bitstream module

83fb2d7

run code formatters

c3a91a6

Run cargo clippy --fix

c873193

Run cargo fmt --all

37e126a

prateekmedia reviewed Dec 26, 2024

View reviewed changes

mrswastik-robot and others added 11 commits December 27, 2024 21:53

refactor: remove rust pointer from C struct

666a1bf

feat: Add bitstream module

d70fcd3

run code formatters

e9a9155

Run cargo clippy --fix

bdb0c5f

Run cargo fmt --all

d869d7c

refactor: remove rust pointer from C struct

04a0eed

Added Bitstream to libccxr_exports

e04b430

Merge branch 'migration-bitstream-module' into migration-module-changes

0ebccad

Merge pull request #1 from steel-bucket/migration-module-changes

b1284d2

Migration module changes

Minor Formatting Issue

22a7259

Merge pull request #2 from steel-bucket/bitstream-fmt-issue

4ac2792

Minor Formatting Issue

prateekmedia requested a review from Copilot June 21, 2025 09:05

Copilot AI reviewed Jun 21, 2025

View reviewed changes

src/rust/lib_ccxr/src/util/bits.rs Show resolved Hide resolved

src/rust/lib_ccxr/src/common/mod.rs Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FEAT] Add `bitstream` module in `lib_ccxr` #1649

[FEAT] Add `bitstream` module in `lib_ccxr` #1649

Uh oh!

mrswastik-robot commented Dec 25, 2024

Uh oh!

prateekmedia Dec 26, 2024

Uh oh!

mrswastik-robot Dec 26, 2024

Uh oh!

mrswastik-robot Dec 29, 2024

Uh oh!

prateekmedia Dec 29, 2024

Uh oh!

ccextractor-bot commented Jun 14, 2025

Uh oh!

ccextractor-bot commented Jun 14, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[FEAT] Add bitstream module in lib_ccxr #1649

Are you sure you want to change the base?

[FEAT] Add bitstream module in lib_ccxr #1649

Uh oh!

Conversation

mrswastik-robot commented Dec 25, 2024

Uh oh!

prateekmedia Dec 26, 2024

Choose a reason for hiding this comment

Uh oh!

mrswastik-robot Dec 26, 2024

Choose a reason for hiding this comment

Uh oh!

mrswastik-robot Dec 29, 2024

Choose a reason for hiding this comment

Uh oh!

prateekmedia Dec 29, 2024

Choose a reason for hiding this comment

Uh oh!

ccextractor-bot commented Jun 14, 2025

Uh oh!

ccextractor-bot commented Jun 14, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[FEAT] Add `bitstream` module in `lib_ccxr` #1649

[FEAT] Add `bitstream` module in `lib_ccxr` #1649