Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

38 integrate palmyra with google drive api #39

Closed
wants to merge 21 commits into from

Conversation

vulongphan
Copy link
Collaborator

This PR implements the following

  • Allow uploading files to Google Drive (new files are created and existing files are updated)
  • Enforce persistence for Google authentication (users do not have to authenticate the second time in the same session)
  • Enable Google Drive file picker pop-up for retrieving uploaded files

@vulongphan vulongphan linked an issue Mar 21, 2023 that may be closed by this pull request
Copy link
Collaborator

@muhammed-abuodeh muhammed-abuodeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(commit 73b4f52) is it fine for the GCP_CLIENT_ID and GCP_API_KEY to be public (just making sure)?

Copy link
Collaborator

@muhammed-abuodeh muhammed-abuodeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change #saveremote to #saveRemote

Copy link
Collaborator

@muhammed-abuodeh muhammed-abuodeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saveremoteToggle() -> saveRemoteToggle
make sure naming is consistent

@vulongphan
Copy link
Collaborator Author

(commit 73b4f52) is it fine for the GCP_CLIENT_ID and GCP_API_KEY to be public (just making sure)?

Yes, I think this is not the best practice. A workaround would be to set environment variables in Github Page; and since I do not have access to the repo settings, we would need to work together on this

@vulongphan vulongphan force-pushed the 38-integrate-palmyra-with-google-drive-api branch from 7a69d63 to ba46636 Compare May 10, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Palmyra with Google Drive API
2 participants