-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
38 integrate palmyra with google drive api #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(commit 73b4f52) is it fine for the GCP_CLIENT_ID and GCP_API_KEY to be public (just making sure)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change #saveremote to #saveRemote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saveremoteToggle() -> saveRemoteToggle
make sure naming is consistent
Yes, I think this is not the best practice. A workaround would be to set environment variables in Github Page; and since I do not have access to the repo settings, we would need to work together on this |
7a69d63
to
ba46636
Compare
This reverts commit 081e008. reverting back to where long finalized the google login functionality
This PR implements the following