26 add tests to simulate user actions #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.test.js
Outdated
|
|
||
| test('Click on treebtn without adding a conll file and a config file', async () => { |
There was a problem hiding this comment.
The goal of this test is to upload a config file, but not a conll file, and we expect it to show the dialogue message.
main.test.js
Outdated
| page = await browser.newPage(); | ||
| // await page.setContent(contentHtml, { waitUntil: "networkidle0" }); | ||
| // await page.addScriptTag({path: "main.js"}); | ||
| await page.goto("http://127.0.0.1:5500/viewtree.html"); // do this to be able to call functions in main.js, might need to direct the browser at this url |
There was a problem hiding this comment.
use https://camel-lab.github.io/palmyra/viewtree.html , it works! This way, we test what annotators are using online, and it isn't restricted to your local configuration.
| expect(testingPosTagsText).toEqual(expectedPosTagsText); | ||
| }); | ||
|
|
||
| test('Click on treebtn with adding a conll file', async () => { |
There was a problem hiding this comment.
is it possible to also assert the number of sentences/trees?
muhammed-abuodeh
requested changes
Nov 3, 2022
muhammed-abuodeh
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses puppeteer to test 8 different combinations of user uploading actions