-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): restore green main (workflow callers, type errors, coverage, hardening) #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
496524c
6c9b634
bcdad33
63be743
95585f5
b76c478
80dac4d
a4ad68c
1b22b47
cd3be61
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -54,11 +54,16 @@ jobs: | |||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||
|
|
||||||||||||||
| steps: | ||||||||||||||
| - name: Harden the runner | ||||||||||||||
| uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1 | ||||||||||||||
| with: | ||||||||||||||
| egress-policy: audit | ||||||||||||||
|
|
||||||||||||||
| - name: Checkout repository | ||||||||||||||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||||||||||||||
|
Comment on lines
62
to
63
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial | ⚡ Quick win Set Neither 🛡️ Proposed hardening (apply to both checkout steps) - name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+ with:
+ persist-credentials: falseAs per coding guidelines for 📝 Committable suggestion
Suggested change
🧰 Tools🪛 zizmor (1.25.2)[warning] 62-63: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false (artipacked) 🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| - name: Install uv | ||||||||||||||
| uses: astral-sh/setup-uv@v7 | ||||||||||||||
| uses: astral-sh/setup-uv@2ddd2b9cb38ad8efd50337e8ab201519a34c9f24 # v7.1.1 | ||||||||||||||
| with: | ||||||||||||||
| enable-cache: true | ||||||||||||||
|
|
||||||||||||||
|
|
@@ -200,11 +205,16 @@ jobs: | |||||||||||||
| needs: fips-check | ||||||||||||||
|
|
||||||||||||||
| steps: | ||||||||||||||
| - name: Harden the runner | ||||||||||||||
| uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1 | ||||||||||||||
| with: | ||||||||||||||
| egress-policy: audit | ||||||||||||||
|
|
||||||||||||||
| - name: Checkout repository | ||||||||||||||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||||||||||||||
|
|
||||||||||||||
| - name: Install uv | ||||||||||||||
| uses: astral-sh/setup-uv@v7 | ||||||||||||||
| uses: astral-sh/setup-uv@2ddd2b9cb38ad8efd50337e8ab201519a34c9f24 # v7.1.1 | ||||||||||||||
| with: | ||||||||||||||
| enable-cache: true | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | ⚡ Quick win
Set
persist-credentials: falseon checkout.This job only reads the dependency diff and never pushes, so the
GITHUB_TOKENdoes not need to persist in.git/config. Disabling persistence reduces the credential-exfiltration surface for the subsequently invoked third-party action.🛡️ Proposed hardening
- name: Checkout repository uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + with: + persist-credentials: falseAs per coding guidelines for
.github/workflows/**: review for "Security best practices (minimal permissions, pinned actions)" and "Proper secret handling".📝 Committable suggestion
🧰 Tools
🪛 zizmor (1.25.2)
[warning] 32-33: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
🤖 Prompt for AI Agents