fix(scorecard): remove self-scorecard job that fails publish verification

.github/workflows/scorecard.yml

@@ -26,60 +26,3 @@ jobs:
       contents: read
       actions: read
     uses: ByronWilliamsCPA/.github/.github/workflows/python-scorecard.yml@6f71aecae2c91214ca0a0a2206a36cf912aa31ac  # main
-
-  self-scorecard:
-    name: OpenSSF Scorecard (this repo)
-    runs-on: ubuntu-latest
-    # #ASSUME: This job runs in the context of ByronWilliamsCPA/.github directly.
-    # The OIDC token repository claim resolves to ByronWilliamsCPA/.github, which
-    # is the correct value for publish_results: true. See docs/architecture/adr-001.
-    # #VERIFY: After first successful run, confirm the "Run Scorecard analysis" step
-    # log shows repository=ByronWilliamsCPA/.github in the OIDC token claims, and
-    # that results appear at securityscorecards.dev/viewer/?uri=github.com/ByronWilliamsCPA/.github
-    timeout-minutes: 15
-    permissions:
-      security-events: write
-      id-token: write
-      contents: read
-      actions: read
-    steps:
-      - name: Verify SCORECARD_TOKEN is set
-        env:
-          TOKEN_SET: ${{ secrets.SCORECARD_TOKEN != '' }}
-        run: |
-          if [ "$TOKEN_SET" != "true" ]; then
-            echo "::error::SCORECARD_TOKEN secret is not set. publish_results: true requires this token."
-            exit 1
-          fi
-
-      - name: Harden runner
-        uses: step-security/harden-runner@ab7a9404c0f3da075243ca237b5fac12c98deaa5  # v2.19.3
-        with:
-          egress-policy: audit
-          disable-sudo: true
-
-      - name: Checkout
-        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
-        with:
-          persist-credentials: false
-
-      - name: Run Scorecard analysis
-        uses: ossf/scorecard-action@4eaacf0543bb3f2c246792bd56e8cdeffafb205a  # v2.4.3
-        with:
-          results_file: results.sarif
-          results_format: sarif
-          repo_token: ${{ secrets.SCORECARD_TOKEN }}
-          publish_results: true
-
-      - name: Upload SARIF results
-        uses: github/codeql-action/upload-sarif@9e0d7b8d25671d64c341c19c0152d693099fb5ba  # v4.35.5
-        with:
-          sarif_file: results.sarif
-          category: scorecard
-
-      - name: Scorecard summary
-        if: always()
-        run: |
-          echo "## OpenSSF Scorecard (this repo)" >> "$GITHUB_STEP_SUMMARY"
-          echo "" >> "$GITHUB_STEP_SUMMARY"
-          echo "Dashboard: https://securityscorecards.dev/viewer/?uri=github.com/ByronWilliamsCPA/.github" >> "$GITHUB_STEP_SUMMARY"