Implement memory_usage() for major jiff types.#521
Open
inklesspen wants to merge 3 commits intoBurntSushi:masterfrom
Open
Implement memory_usage() for major jiff types.#521inklesspen wants to merge 3 commits intoBurntSushi:masterfrom
inklesspen wants to merge 3 commits intoBurntSushi:masterfrom
Conversation
These routines give the heap usage by these types, which can be useful when tracking cache sizes. I did not implement the routine for formatting/rounding/etc types, since these seem unlikely to be held in caches. Fixes BurntSushi#520.
Owner
|
Thanks! I don't think we need to add this for Copy types. |
Author
|
That's fair! Also I guess I misunderstood how the |
Owner
|
Right. std implies alloc. |
Author
|
Let me know if you want me to squash down the three commits; otherwise I'll assume the current PR state is fine. |
Author
|
Is there anything further you need to allow this to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These routines give the heap usage by these types, which can be useful when tracking cache sizes.
I did not implement the routine for formatting/rounding/etc types, since these seem unlikely to be held in caches.
Fixes #520.