feat: CSVReader typescript improvements | style object type casting refactoring#150
feat: CSVReader typescript improvements | style object type casting refactoring#150berkinanik wants to merge 11 commits intoBunlong:masterfrom
Conversation
|
|
js-docs for
generic element type provides proper event handler, event and children render function's arguments proper types first generic type is the parsed result's data type which affects return result type
Thanks to properly typed children render function arguments and all the return types of those argument methods, now children render function is properly typed and proper types are inferred Inferred types of those renderer func arguments, all that methods return proper props of the elements for the spread operation All the events themselves and the handler function types are properly inferred |
234235f to
cddad8e
Compare
d04bd9d to
3339b6e
Compare
|
why hasn't this been merged yet :( |
|
Thanks @berkinanik ❤️ @Bunlong can we merge this? it's awesome |
|
This would be awesome to merge! @Bunlong |
|
Any blocker here? @Bunlong would love to have this |

















resolves #149
useCSVReaderhook andCSVReadercomponent.CSSPropertiescasting.might be considered as a breaking change proposal
Important parts are under: useCSVReader.tsx